* [PATCH 08/13] irda: remove spin_is_locked
[not found] <1332895637-32572-1-git-send-email-andi@firstfloor.org>
@ 2012-03-28 0:47 ` Andi Kleen
2012-03-28 1:32 ` David Miller
2012-03-28 0:47 ` [PATCH 10/13] smsc911x: Use lockdep_assert_held instead of home grown buggy construct Andi Kleen
1 sibling, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2012-03-28 0:47 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, Andi Kleen, netdev, samuel
From: Andi Kleen <ak@linux.intel.com>
It's hard to imagine how this spin_is_locked debugging check is not
totally racy. Remove it.
Cc: netdev@vger.kernel.org
Cc: samuel@sortiz.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
drivers/net/irda/sir_dev.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/net/irda/sir_dev.c b/drivers/net/irda/sir_dev.c
index 5039f08..90a1b3e 100644
--- a/drivers/net/irda/sir_dev.c
+++ b/drivers/net/irda/sir_dev.c
@@ -632,11 +632,6 @@ static netdev_tx_t sirdev_hard_xmit(struct sk_buff *skb,
/* Init tx buffer*/
dev->tx_buff.data = dev->tx_buff.head;
- /* Check problems */
- if(spin_is_locked(&dev->tx_lock)) {
- IRDA_DEBUG(3, "%s(), write not completed\n", __func__);
- }
-
/* serialize with write completion */
spin_lock_irqsave(&dev->tx_lock, flags);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 10/13] smsc911x: Use lockdep_assert_held instead of home grown buggy construct
[not found] <1332895637-32572-1-git-send-email-andi@firstfloor.org>
2012-03-28 0:47 ` [PATCH 08/13] irda: remove spin_is_locked Andi Kleen
@ 2012-03-28 0:47 ` Andi Kleen
2012-03-28 1:32 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2012-03-28 0:47 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, Andi Kleen, netdev
From: Andi Kleen <ak@linux.intel.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
drivers/net/ethernet/smsc/smsc911x.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.h b/drivers/net/ethernet/smsc/smsc911x.h
index 9ad5e5d..4fbb697 100644
--- a/drivers/net/ethernet/smsc/smsc911x.h
+++ b/drivers/net/ethernet/smsc/smsc911x.h
@@ -52,7 +52,7 @@
#ifdef CONFIG_DEBUG_SPINLOCK
#define SMSC_ASSERT_MAC_LOCK(pdata) \
- WARN_ON(!spin_is_locked(&pdata->mac_lock))
+ lockdep_assert_held(&(pdata)->mac_lock)
#else
#define SMSC_ASSERT_MAC_LOCK(pdata) do {} while (0)
#endif /* CONFIG_DEBUG_SPINLOCK */
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 08/13] irda: remove spin_is_locked
2012-03-28 0:47 ` [PATCH 08/13] irda: remove spin_is_locked Andi Kleen
@ 2012-03-28 1:32 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-03-28 1:32 UTC (permalink / raw)
To: andi; +Cc: akpm, linux-kernel, ak, netdev, samuel
From: Andi Kleen <andi@firstfloor.org>
Date: Tue, 27 Mar 2012 17:47:12 -0700
> From: Andi Kleen <ak@linux.intel.com>
>
> It's hard to imagine how this spin_is_locked debugging check is not
> totally racy. Remove it.
>
> Cc: netdev@vger.kernel.org
> Cc: samuel@sortiz.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 10/13] smsc911x: Use lockdep_assert_held instead of home grown buggy construct
2012-03-28 0:47 ` [PATCH 10/13] smsc911x: Use lockdep_assert_held instead of home grown buggy construct Andi Kleen
@ 2012-03-28 1:32 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-03-28 1:32 UTC (permalink / raw)
To: andi; +Cc: akpm, linux-kernel, ak, netdev
From: Andi Kleen <andi@firstfloor.org>
Date: Tue, 27 Mar 2012 17:47:14 -0700
> From: Andi Kleen <ak@linux.intel.com>
>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-28 1:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1332895637-32572-1-git-send-email-andi@firstfloor.org>
2012-03-28 0:47 ` [PATCH 08/13] irda: remove spin_is_locked Andi Kleen
2012-03-28 1:32 ` David Miller
2012-03-28 0:47 ` [PATCH 10/13] smsc911x: Use lockdep_assert_held instead of home grown buggy construct Andi Kleen
2012-03-28 1:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).