[PATCH] f_phonet: fix skb truesize underestimation

[PATCH] f_phonet: fix skb truesize underestimation

[Eric Dumazet]

Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
properly account truesize of each fragment : a full page.

Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: Rémi Denis-Courmont <remi.denis-courmont-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
---
 drivers/usb/gadget/f_phonet.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget/f_phonet.c
index 85a5ceb..965a629 100644
--- a/drivers/usb/gadget/f_phonet.c
+++ b/drivers/usb/gadget/f_phonet.c
@@ -345,7 +345,7 @@ static void pn_rx_complete(struct usb_ep *ep, struct usb_request *req)
 		}
 
 		skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, page,
-				skb->len <= 1, req->actual, req->actual);
+				skb->len <= 1, req->actual, PAGE_SIZE);
 		page = NULL;
 
 		if (req->actual < req->length) { /* Last fragment */


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] cdc-phonet: fix skb truesize underestimation

[Eric Dumazet]

Now skb_add_rx_frag() has a truesize parameter, we can fix cdc-phonet to
properly account truesize of each fragment : a full page.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
---
 drivers/net/usb/cdc-phonet.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/cdc-phonet.c b/drivers/net/usb/cdc-phonet.c
index 3886b30..3e41b00 100644
--- a/drivers/net/usb/cdc-phonet.c
+++ b/drivers/net/usb/cdc-phonet.c
@@ -165,13 +165,13 @@ static void rx_complete(struct urb *req)
 				memcpy(skb_put(skb, 1), page_address(page), 1);
 				skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
 						page, 1, req->actual_length,
-						req->actual_length);
+						PAGE_SIZE);
 				page = NULL;
 			}
 		} else {
 			skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
 					page, 0, req->actual_length,
-					req->actual_length);
+					PAGE_SIZE);
 			page = NULL;
 		}
 		if (req->actual_length < PAGE_SIZE)

Re: [PATCH] cdc-phonet: fix skb truesize underestimation

[Rémi Denis-Courmont]

Le mardi 27 mars 2012 06:17:26 ext Eric Dumazet a écrit :
> Now skb_add_rx_frag() has a truesize parameter, we can fix cdc-phonet to
> properly account truesize of each fragment : a full page.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

Acked-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

-- 
Rémi Denis-Courmont
http://www.remlab.net/

Re: [PATCH] f_phonet: fix skb truesize underestimation

[David Miller]

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 27 Mar 2012 06:04:02 -0700

> Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
> properly account truesize of each fragment : a full page.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.

Re: [PATCH] cdc-phonet: fix skb truesize underestimation

[David Miller]

From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Tue, 27 Mar 2012 06:17:26 -0700

> Now skb_add_rx_frag() has a truesize parameter, we can fix cdc-phonet to
> properly account truesize of each fragment : a full page.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] f_phonet: fix skb truesize underestimation

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

On Tue, Mar 27, 2012 at 10:51:09PM -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 27 Mar 2012 06:04:02 -0700
> 
> > Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
> > properly account truesize of each fragment : a full page.
> > 
> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> 
> Applied.

did you apply both patches ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] f_phonet: fix skb truesize underestimation

[David Miller]

From: Felipe Balbi <balbi@ti.com>
Date: Wed, 28 Mar 2012 11:55:36 +0300

> On Tue, Mar 27, 2012 at 10:51:09PM -0400, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Tue, 27 Mar 2012 06:04:02 -0700
>> 
>> > Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
>> > properly account truesize of each fragment : a full page.
>> > 
>> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>> 
>> Applied.
> 
> did you apply both patches ?

You never need to ask me these kinds of questions, you can
either check my GIT tree or look at:

http://patchwork.ozlabs.org/project/netdev/list/?state=3

Re: [PATCH] f_phonet: fix skb truesize underestimation

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On Wed, Mar 28, 2012 at 05:33:10AM -0400, David Miller wrote:
> From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> Date: Wed, 28 Mar 2012 11:55:36 +0300
> 
> > On Tue, Mar 27, 2012 at 10:51:09PM -0400, David Miller wrote:
> >> From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> Date: Tue, 27 Mar 2012 06:04:02 -0700
> >> 
> >> > Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
> >> > properly account truesize of each fragment : a full page.
> >> > 
> >> > Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> 
> >> Applied.
> > 
> > did you apply both patches ?
> 
> You never need to ask me these kinds of questions, you can
> either check my GIT tree or look at:
> 
> http://patchwork.ozlabs.org/project/netdev/list/?state=3

I'm asking because drivers/usb/gadget/ should either go through me or
you should wait for my Acked-by. Now it's too late for that, but next
time for my Ack.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] f_phonet: fix skb truesize underestimation

[Paul Gortmaker]

On Wed, Mar 28, 2012 at 8:43 AM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
> On Wed, Mar 28, 2012 at 05:33:10AM -0400, David Miller wrote:
>> From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>> Date: Wed, 28 Mar 2012 11:55:36 +0300
>>
>> > On Tue, Mar 27, 2012 at 10:51:09PM -0400, David Miller wrote:
>> >> From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >> Date: Tue, 27 Mar 2012 06:04:02 -0700
>> >>
>> >> > Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
>> >> > properly account truesize of each fragment : a full page.
>> >> >
>> >> > Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >>
>> >> Applied.
>> >
>> > did you apply both patches ?
>>
>> You never need to ask me these kinds of questions, you can
>> either check my GIT tree or look at:
>>
>> http://patchwork.ozlabs.org/project/netdev/list/?state=3
>
> I'm asking because drivers/usb/gadget/ should either go through me or
> you should wait for my Acked-by. Now it's too late for that, but next
> time for my Ack.

Hi Felipe,

Being in the MAINTAINERS file is best interpreted as "I care about
this driver/code/subsystem, and I'll do my best to fix/integrate for it,
and I want to know about changes to it".

It has never meant that all patches to that MAINTAINER's code must
be OK'd by that one particular maintainer before being committed.

In the last twenty years, I can't ever recall any one driver/subsystem
where one individual had the ultimate veto (excluding Linus).  And
that is a good thing.

If a commit has dependencies to low level skb accounting, then it
makes perfect sense for it to be in the tree where those accounting
changes are made.  Even more sense for it to be done by the
people who know those internals better than anyone else.

Speaking for myself, if I had networking code that Eric and Dave
made changes to, I'd be pretty damn happy that smarter people
than myself did the changes for me, and that they were nice enough
to have CC'd me on the changes as a courtesy.

Just my $0.02.
Paul.

>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] f_phonet: fix skb truesize underestimation

[Rémi Denis-Courmont]

Le mardi 27 mars 2012 22:51:09 ext David Miller a écrit :
> From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date: Tue, 27 Mar 2012 06:04:02 -0700
> 
> > Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
> > properly account truesize of each fragment : a full page.
> > 
> > Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Applied.

Sorry for not reviewing. My evil corporate mail transfer agent apparently ate 
that patch :-(

I guess I should use my personal email instead...

-- 
Rémi Denis-Courmont
http://www.remlab.net/

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] f_phonet: fix skb truesize underestimation

[Eric Dumazet]

On Thu, 2012-03-29 at 09:30 +0300, Rémi Denis-Courmont wrote:
> Le mardi 27 mars 2012 22:51:09 ext David Miller a écrit :
> > From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Date: Tue, 27 Mar 2012 06:04:02 -0700
> > 
> > > Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
> > > properly account truesize of each fragment : a full page.
> > > 
> > > Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > 
> > Applied.
> 
> Sorry for not reviewing. My evil corporate mail transfer agent apparently ate 
> that patch :-(
> 
> I guess I should use my personal email instead...
> 

Thats true, I got a funny reject from your mail server, stating :

"Your domain is blocked with bad reputation defined by CommTouch: ...
(state 13)"

gmail.com has bad reputation ? Come on !



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] f_phonet: fix skb truesize underestimation

[David Miller]

From: Rémi Denis-Courmont <remi.denis-courmont-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Date: Thu, 29 Mar 2012 09:30:32 +0300

> I guess I should use my personal email instead...

nokia.com tends to eat 2 out of every 3 mailing list postings
on vger.kernel.org, so yes I'd say using person email would
be a good idea
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html