From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [Q/RFC] BPF use in broader scope Date: Thu, 29 Mar 2012 11:31:58 +0200 Message-ID: <20120329093158.GA2275@minipsycho.brq.redhat.com> References: <20120329074443.GB2098@minipsycho> <20120329.034957.655153582806618222.davem@davemloft.net> <20120329075410.GC2098@minipsycho> <1333008145.2325.275.camel@edumazet-glaptop> <20120329083149.GD2098@minipsycho> <1333010732.2325.339.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , netdev@vger.kernel.org, bhutchings@solarflare.com, shemminger@vyatta.com, matt@ozlabs.org To: Eric Dumazet Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64757 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753409Ab2C2JcI (ORCPT ); Thu, 29 Mar 2012 05:32:08 -0400 Content-Disposition: inline In-Reply-To: <1333010732.2325.339.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Mar 29, 2012 at 10:45:32AM CEST, eric.dumazet@gmail.com wrote: >On Thu, 2012-03-29 at 10:31 +0200, Jiri Pirko wrote: >> Thu, Mar 29, 2012 at 10:02:25AM CEST, eric.dumazet@gmail.com wrote: >> >On Thu, 2012-03-29 at 09:54 +0200, Jiri Pirko wrote: >> > >> >> Yep, I'm aware. I must admit that the JIT code scares me a litte :( >> >> >> > >> >If you add a new XOR instruction in interpreter only, JIT compiler will >> >automatically aborts, so no risk. >> > >> >Each arch maintainer will add the support for the new instructions as >> >separate patches. >> > >> >So you can focus on net/core/filter.c file only. >> > >> >> Ok - I can do this for 2). But for 3) JITs need to be modified. So I >> would like to kindly ask you and Matt if you can do this modification so >> bpf_func takes pointer to mem (scratch store) as second parameter. I'm >> sure it's very easy for you to do. > >I am not sure why you want this. > >This adds register pressure (at least for x86) ... Well I think that there would become handy to be able to pass some data to bpf_func (other than skb). But it's just an idea. > > >