netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [Q] ipv6: RTM_GETROUTE interpretation of RTA_IIF
@ 2012-03-29 13:03 Shmulik Ladkani
  2012-04-01  6:18 ` ipv6: RTM_GETROUTE inconsistent " Shmulik Ladkani
  0 siblings, 1 reply; 4+ messages in thread
From: Shmulik Ladkani @ 2012-03-29 13:03 UTC (permalink / raw)
  To: netdev

Hi,

In IPv4, if the RTA_IIF attribute is specified in an RTM_GETROUTE
message, then a route is searched as if a packet was received on the
specified iif interface - i.e. 'inet_rtm_getroute()' calls
'ip_route_input()'.

However in IPv6, RTA_IIF is not interpreted in the same way:
'inet6_rtm_getroute()' always calls 'ip6_route_output()', regardless the
RTA_IIF attribute.

As a result, in IPv6 there's no way to use RTM_GETROUTE in order to look
for a route as if a packet was received on a specific interface.

I'd like to modify 'inet6_rtm_getroute()' so that RTA_IIF is interpreted
in the same way as in IPv4's 'inet_rtm_getroute()'.

Before I come up with a patch, I'd like to know whether current
interpretation of RTA_IIF in 'inet6_rtm_getroute()' is deliberate.

Regards,
Shmulik

^ permalink raw reply	[flat|nested] 4+ messages in thread

* ipv6: RTM_GETROUTE inconsistent interpretation of RTA_IIF
  2012-03-29 13:03 [Q] ipv6: RTM_GETROUTE interpretation of RTA_IIF Shmulik Ladkani
@ 2012-04-01  6:18 ` Shmulik Ladkani
  2012-04-01  7:03   ` Eric Dumazet
  0 siblings, 1 reply; 4+ messages in thread
From: Shmulik Ladkani @ 2012-04-01  6:18 UTC (permalink / raw)
  To: netdev, davem; +Cc: kuznet, jmorris, yoshfuji, kaber

(Bump)

Any reason not to submit a patch that fixes the below issue?

Regards,
Shmulik

On Thu, 29 Mar 2012 15:03:11 +0200 Shmulik Ladkani <shmulik.ladkani@gmail.com> wrote:
> Hi,
> 
> In IPv4, if the RTA_IIF attribute is specified in an RTM_GETROUTE
> message, then a route is searched as if a packet was received on the
> specified iif interface - i.e. 'inet_rtm_getroute()' calls
> 'ip_route_input()'.
> 
> However in IPv6, RTA_IIF is not interpreted in the same way:
> 'inet6_rtm_getroute()' always calls 'ip6_route_output()', regardless the
> RTA_IIF attribute.
> 
> As a result, in IPv6 there's no way to use RTM_GETROUTE in order to look
> for a route as if a packet was received on a specific interface.
> 
> I'd like to modify 'inet6_rtm_getroute()' so that RTA_IIF is interpreted
> in the same way as in IPv4's 'inet_rtm_getroute()'.
> 
> Before I come up with a patch, I'd like to know whether current
> interpretation of RTA_IIF in 'inet6_rtm_getroute()' is deliberate.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ipv6: RTM_GETROUTE inconsistent interpretation of RTA_IIF
  2012-04-01  6:18 ` ipv6: RTM_GETROUTE inconsistent " Shmulik Ladkani
@ 2012-04-01  7:03   ` Eric Dumazet
  2012-04-01  7:28     ` Shmulik Ladkani
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2012-04-01  7:03 UTC (permalink / raw)
  To: Shmulik Ladkani; +Cc: netdev, davem, kuznet, jmorris, yoshfuji, kaber

On Sun, 2012-04-01 at 09:18 +0300, Shmulik Ladkani wrote:
> (Bump)
> 
> Any reason not to submit a patch that fixes the below issue?

Hi Shmulik

No reason I can think about. Are you planning to provide this yourself ?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ipv6: RTM_GETROUTE inconsistent interpretation of RTA_IIF
  2012-04-01  7:03   ` Eric Dumazet
@ 2012-04-01  7:28     ` Shmulik Ladkani
  0 siblings, 0 replies; 4+ messages in thread
From: Shmulik Ladkani @ 2012-04-01  7:28 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: netdev, davem, kuznet, jmorris, yoshfuji, kaber

On Sun, 01 Apr 2012 09:03:59 +0200 Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Sun, 2012-04-01 at 09:18 +0300, Shmulik Ladkani wrote:
> > (Bump)
> > 
> > Any reason not to submit a patch that fixes the below issue?
> 
> Hi Shmulik
> 
> No reason I can think about. Are you planning to provide this yourself ?

Yes.

Just wanted to make sure ipv6's RTA_IIF interpretation is not deliberate.

Regards,
Shmulik

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-04-01  7:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-29 13:03 [Q] ipv6: RTM_GETROUTE interpretation of RTA_IIF Shmulik Ladkani
2012-04-01  6:18 ` ipv6: RTM_GETROUTE inconsistent " Shmulik Ladkani
2012-04-01  7:03   ` Eric Dumazet
2012-04-01  7:28     ` Shmulik Ladkani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).