From: David Miller <davem@davemloft.net>
To: fernando@intellilink.co.jp
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3] TCP: update ip_local_port_range documentation
Date: Tue, 03 Apr 2012 17:40:37 -0400 (EDT) [thread overview]
Message-ID: <20120403.174037.1557770873488371175.davem@davemloft.net> (raw)
In-Reply-To: <20120404034140.9qatex0wg8ccok4o@webmail.int.intellilink.co.jp>
From: fernando@intellilink.co.jp
Date: Wed, 4 Apr 2012 03:41:40 +0900
> I forgot to add my Signed-off-by and the patch explanation.
> I am aosrry for the noise. Updated patch attached.
Since you put this at the top of the message body, I had to
edit it out of the patch submission by hand.
Your commit message proper needed to be edited by hand as well
because there were missing spaces between the Documentation
file path and the word that came right afterwards.
Furthermore, you had trailing whitespace in your patch, which I also
had to fix up by hand.
You know, this wasn't exactly a rocket-science patch, I spent more
time fixing up your patch than I would have spend implementing
the patch myself. That is _never_ a good sign.
prev parent reply other threads:[~2012-04-03 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 0:48 [PATCH 1/2] TCP: update ip_local_port_range documentation fernando
2012-04-03 0:50 ` [PATCH 2/2] TCP: Use 32768-65535 outgoing port range by default fernando
2012-04-03 4:50 ` David Miller
2012-04-03 5:18 ` fernando
2012-04-03 6:28 ` David Miller
2012-04-03 4:54 ` [PATCH 1/2] TCP: update ip_local_port_range documentation David Miller
2012-04-03 4:59 ` fernando
2012-04-03 11:08 ` fernando
2012-04-03 11:12 ` [PATCH] " fernando
2012-04-03 18:41 ` [PATCH v3] " fernando
2012-04-03 21:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403.174037.1557770873488371175.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fernando@intellilink.co.jp \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).