From: David Miller <davem@davemloft.net>
To: srinivas.kandagatla@st.com
Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com
Subject: Re: [PATCH 3.3.0] phy:icplus:fix Auto Power Saving in ip101a_config_init.
Date: Tue, 03 Apr 2012 18:49:37 -0400 (EDT) [thread overview]
Message-ID: <20120403.184937.744089580257691570.davem@davemloft.net> (raw)
In-Reply-To: <1333360929-31506-1-git-send-email-srinivas.kandagatla@st.com>
From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
Date: Mon, 2 Apr 2012 11:02:09 +0100
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> This patch fixes Auto Power Saving configuration in ip101a_config_init
> which was broken as there is no phy register write followed after
> setting IP101A_APS_ON flag.
>
> This patch also fixes the return value of ip101a_config_init.
>
> Without this patch ip101a_config_init returns 2 which is not an error
> accroding to IS_ERR and the mac driver will continue accessing 2 as
> valid pointer to phy_dev resulting in memory fault.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2012-04-03 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 10:02 [PATCH 3.3.0] phy:icplus:fix Auto Power Saving in ip101a_config_init Srinivas KANDAGATLA
2012-04-03 22:49 ` David Miller [this message]
2012-05-09 7:25 ` Jonathan Nieder
2012-05-09 15:57 ` David Miller
2012-05-09 17:18 ` [3.2.y] " Jonathan Nieder
2012-05-12 0:57 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403.184937.744089580257691570.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=srinivas.kandagatla@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).