From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] netfilter: xt_CT: remove a compile warning
Date: Tue, 3 Apr 2012 11:35:38 +0200 [thread overview]
Message-ID: <20120403093538.GA20140@1984> (raw)
In-Reply-To: <1333441883.18626.60.camel@edumazet-glaptop>
On Tue, Apr 03, 2012 at 10:31:23AM +0200, Eric Dumazet wrote:
> On Tue, 2012-04-03 at 10:17 +0200, Pablo Neira Ayuso wrote:
> > On Tue, Apr 03, 2012 at 05:48:22AM +0200, Eric Dumazet wrote:
> > > If CONFIG_NF_CONNTRACK_TIMEOUT=n we have following warning :
> > >
> > > CC [M] net/netfilter/xt_CT.o
> > > net/netfilter/xt_CT.c: In function ‘xt_ct_tg_check_v1’:
> > > net/netfilter/xt_CT.c:284: warning: label ‘err4’ defined but not used
> >
> > Thanks Eric.
> >
> > I think I prefer the one attached.
> >
> > I 'll pass it to davem with a couple of other minor fixes anytime soon.
>
> Its your call, but you should move the whole
>
> #if CONFIG_NF_CONNTRACK_TIMEOUT
> ... lot of lines ...
> #endif
>
> in a helper function to make things a bit more maintainable
I will, thanks for the suggestion.
prev parent reply other threads:[~2012-04-03 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 3:48 [PATCH] netfilter: xt_CT: remove a compile warning Eric Dumazet
2012-04-03 8:17 ` Pablo Neira Ayuso
2012-04-03 8:31 ` Eric Dumazet
2012-04-03 9:35 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403093538.GA20140@1984 \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).