From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, ncardwell@google.com,
therbert@google.com, ycheng@google.com, hkchu@google.com,
maze@google.com, maheshb@google.com, ilpo.jarvinen@helsinki.fi,
nanditad@google.com
Subject: Re: [PATCH] tcp: allow splice() to build full TSO packets
Date: Wed, 04 Apr 2012 02:20:06 -0400 (EDT) [thread overview]
Message-ID: <20120404.022006.438740898640436561.davem@davemloft.net> (raw)
In-Reply-To: <1333520128.18626.382.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 04 Apr 2012 08:15:28 +0200
> On Tue, 2012-04-03 at 18:50 -0400, David Miller wrote:
>
>> Eric, sorry to be a pain, but to clear my conscience can you tell me
>> if the sendfile() path do the right thing with your change too?
>>
>> I'm concerned about returning back into userspace without at least
>> one tcp_push() at the end.
>
> Absolutely, this patch also handles the sendfile() path.
>
> do_sendfile() ->
> do_splice_direct() ->
> splice_direct_to_actor() ->
> ...
> splice_from_pipe() ->
> splice_from_pipe_feed() ->
> pipe_to_sendpage() more = (sd->flags & SPLICE_F_MORE) || sd->len < sd->total_len
> sock_sendpage() if (more) flags |= MSG_MORE;
> kernel_sendpage()
> inet_sendpage()
> tcp_sendpage()
>
> So the push is perfomed at the end (last page doesnt have MSG_MORE flag)
Perfect, thanks for double checking.
next prev parent reply other threads:[~2012-04-04 6:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 19:37 [PATCH] tcp: allow splice() to build full TSO packets Eric Dumazet
2012-04-03 21:21 ` David Miller
2012-04-03 21:31 ` Eric Dumazet
2012-04-03 21:36 ` David Miller
2012-04-03 22:50 ` David Miller
2012-04-04 6:15 ` Eric Dumazet
2012-04-04 6:20 ` David Miller [this message]
2012-04-05 13:05 ` Eric Dumazet
2012-04-05 23:05 ` David Miller
2012-04-06 1:59 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404.022006.438740898640436561.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hkchu@google.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).