From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
bhutchings@solarflare.com, shemminger@vyatta.com,
raise.sail@gmail.com, nuno.martins@caixamagica.pt,
matt@ozlabs.org
Subject: Re: [patch net-next 3/4] team: add binary option type
Date: Wed, 04 Apr 2012 17:45:47 -0400 (EDT) [thread overview]
Message-ID: <20120404.174547.1002799463139854012.davem@davemloft.net> (raw)
In-Reply-To: <20120404122930.GD2202@minipsycho.brq.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Wed, 4 Apr 2012 14:29:31 +0200
> Wed, Apr 04, 2012 at 12:38:16AM CEST, davem@davemloft.net wrote:
>>From: Jiri Pirko <jpirko@redhat.com>
>>Date: Sat, 31 Mar 2012 23:01:21 +0200
>>
>>> For transfering generic binary data (e.g. BPF code), introduce new
>>> binary option type.
>>>
>>> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>>
>>Several issues:
>>
>>> + struct team_option_binary tbinary;
>>
>>You put this into a netlink attribute, it has a non-fixed
>>type size because it uses pointer. A compat task will do
>>the wrong thing and you won't interpret it's attribute
>>correctly.
>
> I'm not nla_putting struct team_option_binary tbinary. I'm putting only
> the data on what the pointer stored into that points (tbinary.data):
>
> nla_put(skb, TEAM_ATTR_OPTION_DATA, tbinary.data_len, tbinary.data));
Aha, I misread, thanks for explaining.
next prev parent reply other threads:[~2012-04-04 21:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 21:01 [patch net-next 0/4] Introduce BPF-based TX port selecting for Team device Jiri Pirko
2012-03-31 21:01 ` [patch net-next 1/4] filter: Allow to create sk-unattached filters Jiri Pirko
2012-04-03 22:36 ` David Miller
2012-03-31 21:01 ` [patch net-next 2/4] filter: add XOR operation Jiri Pirko
2012-04-03 22:36 ` David Miller
2012-03-31 21:01 ` [patch net-next 3/4] team: add binary option type Jiri Pirko
2012-04-03 22:38 ` David Miller
2012-04-04 12:29 ` Jiri Pirko
2012-04-04 21:45 ` David Miller [this message]
2012-04-04 22:14 ` Jiri Pirko
2012-03-31 21:01 ` [patch net-next 4/4] team: add loadbalance mode Jiri Pirko
2012-04-03 22:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404.174547.1002799463139854012.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=matt@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nuno.martins@caixamagica.pt \
--cc=raise.sail@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).