From: David Miller <davem@davemloft.net>
To: ogerlitz@mellanox.com
Cc: roland@kernel.org, netdev@vger.kernel.org, fubar@us.ibm.com,
shlomop@mellanox.com
Subject: Re: [PATCH net V1 2/2] net/bonding: correctly proxy slave neigh param setup ndo function
Date: Wed, 04 Apr 2012 18:12:13 -0400 (EDT) [thread overview]
Message-ID: <20120404.181213.2086357060828338921.davem@davemloft.net> (raw)
In-Reply-To: <1333529780-28421-3-git-send-email-ogerlitz@mellanox.com>
From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Wed, 4 Apr 2012 11:56:20 +0300
> From: Shlomo Pongratz <shlomop@mellanox.com>
>
> The current implemenation was buggy for slaves who use ndo_neigh_setup,
> since the networking stack invokes the bonding device ndo entry (from
> neigh_params_alloc) before any devices are enslaved, and the bonding
> driver can't further delegate the call at that point in time. As a
> result when bonding IPoIB devices, the neigh_cleanup hasn't been called.
>
> Fix that by deferring the actual call into the slave ndo_neigh_setup
> from the time the bonding neigh_setup is called.
>
> Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
Applied.
prev parent reply other threads:[~2012-04-04 22:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 8:56 [PATCH net V1 0/2] net/bonding: fixes related to neigh Or Gerlitz
2012-04-04 8:56 ` [PATCH net V1 1/2] net/bonding: emit address change event also in bond_release Or Gerlitz
2012-04-04 16:57 ` Jay Vosburgh
2012-04-04 22:12 ` David Miller
2012-04-04 8:56 ` [PATCH net V1 2/2] net/bonding: correctly proxy slave neigh param setup ndo function Or Gerlitz
2012-04-04 17:00 ` Jay Vosburgh
2012-04-04 22:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404.181213.2086357060828338921.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@kernel.org \
--cc=shlomop@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).