[PATCH 0/7] bna: Update driver version to 3.0.23.0

[PATCH 0/7] bna: Update driver version to 3.0.23.0

[Jing Huang]

This patch set contains fixes in adapter initialization and tx/rx cleanup path.
It also include code cleanups by removing and renaming some functions.

The driver version has been updated to 3.0.23.0 to reflect the changes.

Jing Huang (7):
  bna: Serialize smem access during adapter initialization
  bna: Flash controller ioc pll init fixes
  bna: ioc cleanups
  bfa: tx rx cleanup fix
  bna: Remove tx tasklet
  bfa: Function name changes and cleanups
  bfa: Update driver version to 3.0.23.0

 drivers/net/ethernet/brocade/bna/bfa_ioc.c      |   61 +++--
 drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c   |  142 +++++++----
 drivers/net/ethernet/brocade/bna/bfi_reg.h      |    6 +
 drivers/net/ethernet/brocade/bna/bnad.c         |  316 +++++++++++------------
 drivers/net/ethernet/brocade/bna/bnad.h         |   11 +-
 drivers/net/ethernet/brocade/bna/bnad_ethtool.c |    6 +-
 6 files changed, 300 insertions(+), 242 deletions(-)

Re: [PATCH 0/7] bna: Update driver version to 3.0.23.0

[David Miller]

From: Jing Huang <huangj@Brocade.COM>
Date: Mon, 26 Mar 2012 12:37:53 -0700

> This patch set contains fixes in adapter initialization and tx/rx cleanup path.
> It also include code cleanups by removing and renaming some functions.
> 
> The driver version has been updated to 3.0.23.0 to reflect the changes.

Cleanups and such are only appropriate for net-next, which is not
open because the merge window is still ongoing.

Re: [PATCH 0/7] bna: Update driver version to 3.0.23.0

[Stephen Hemminger]

On Mon, 26 Mar 2012 12:37:53 -0700
Jing Huang <huangj@brocade.com> wrote:

> This patch set contains fixes in adapter initialization and tx/rx cleanup path.
> It also include code cleanups by removing and renaming some functions.
> 
> The driver version has been updated to 3.0.23.0 to reflect the changes.
> 
> Jing Huang (7):
>   bna: Serialize smem access during adapter initialization
>   bna: Flash controller ioc pll init fixes
>   bna: ioc cleanups
>   bfa: tx rx cleanup fix
>   bna: Remove tx tasklet
>   bfa: Function name changes and cleanups
>   bfa: Update driver version to 3.0.23.0
> 
>  drivers/net/ethernet/brocade/bna/bfa_ioc.c      |   61 +++--
>  drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c   |  142 +++++++----
>  drivers/net/ethernet/brocade/bna/bfi_reg.h      |    6 +
>  drivers/net/ethernet/brocade/bna/bnad.c         |  316 +++++++++++------------
>  drivers/net/ethernet/brocade/bna/bnad.h         |   11 +-
>  drivers/net/ethernet/brocade/bna/bnad_ethtool.c |    6 +-
>  6 files changed, 300 insertions(+), 242 deletions(-)
> 

When are you going to integrate multi-queue support which is already
available in your out of tree driver?

Re: [PATCH 0/7] bna: Update driver version to 3.0.23.0

[David Miller]

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 4 Apr 2012 10:15:35 -0700

> On Mon, 26 Mar 2012 12:37:53 -0700
> Jing Huang <huangj@brocade.com> wrote:
> 
>> This patch set contains fixes in adapter initialization and tx/rx cleanup path.
>> It also include code cleanups by removing and renaming some functions.
>> 
>> The driver version has been updated to 3.0.23.0 to reflect the changes.
>> 
>> Jing Huang (7):
>>   bna: Serialize smem access during adapter initialization
>>   bna: Flash controller ioc pll init fixes
>>   bna: ioc cleanups
>>   bfa: tx rx cleanup fix
>>   bna: Remove tx tasklet
>>   bfa: Function name changes and cleanups
>>   bfa: Update driver version to 3.0.23.0
>> 
>>  drivers/net/ethernet/brocade/bna/bfa_ioc.c      |   61 +++--
>>  drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c   |  142 +++++++----
>>  drivers/net/ethernet/brocade/bna/bfi_reg.h      |    6 +
>>  drivers/net/ethernet/brocade/bna/bnad.c         |  316 +++++++++++------------
>>  drivers/net/ethernet/brocade/bna/bnad.h         |   11 +-
>>  drivers/net/ethernet/brocade/bna/bnad_ethtool.c |    6 +-
>>  6 files changed, 300 insertions(+), 242 deletions(-)
>> 
> 
> When are you going to integrate multi-queue support which is already
> available in your out of tree driver?

I hope your Brocade folks aren't playing the "try to make the out-of-tree
driver more desirable than the in-tree one" game.  I would find that really
irritating.

RE: [PATCH 0/7] bna: Update driver version to 3.0.23.0

[Jing Huang]

>> When are you going to integrate multi-queue support which is already
>> available in your out of tree driver?
>
>I hope your Brocade folks aren't playing the "try to make the out-of-tree
>driver more desirable than the in-tree one" game.  I would find that really
>irritating.

Hi Stephen & David

We submitted our mutli-TX queue implementation last year but it was not accepted. The concern was mainly on our iSCSI over DCB implementation because we had used select_queue() to map iSCSI pkts to a queue derived from DCB configuration by inspecting the well known TCP port number. The community feedback was to use ndo_setup_tc to setup up priority to queue mapping and use dcb_setapp() routines to program the iscsi TLV and provide priority info to user space applications. 

We are working on the implementation for our next driver release and will plan to submit the upstream patch after it has gone through QA validation later this year.

However, if you are ok with the existing implementation, we would like to resubmit the current implementation to enable feature parity with out of box driver.

Thanks
Jing