From: David Miller <davem@davemloft.net>
To: huangj@Brocade.COM
Cc: netdev@vger.kernel.org, AdapterLinuxOpenSrcExtTeam@Brocade.COM
Subject: Re: [PATCH 0/7] bna: Update driver version to 3.0.23.0 (resubmit)
Date: Wed, 04 Apr 2012 18:21:05 -0400 (EDT) [thread overview]
Message-ID: <20120404.182105.1576892492865932011.davem@davemloft.net> (raw)
In-Reply-To: <1333554102-21973-1-git-send-email-huangj@brocade.com>
From: Jing Huang <huangj@Brocade.COM>
Date: Wed, 4 Apr 2012 08:41:42 -0700
> I am resubmit this patch set since it seems that the net-next merge window is
> over.
>
> This patch set contains fixes in adapter initialization and tx/rx cleanup path.
> It also include code cleanups by removing and renaming some functions.
>
> The driver version has been updated to 3.0.23.0 to reflect the changes.
All applied.
But I would suggest modifying how the driver spins waiting for the
firmware to release semaphore bits in registers.
You have no timeouts or limits in these loops.
So if the firmware crashes or gets stuck, this will take out the
entire computer which is very undesirable.
Change these loops to have a limit and signal an error and fail the
top-level operation if the limit is hit.
next prev parent reply other threads:[~2012-04-04 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 15:41 [PATCH 0/7] bna: Update driver version to 3.0.23.0 (resubmit) Jing Huang
2012-04-04 22:21 ` David Miller [this message]
2012-04-04 23:07 ` Jing Huang
2012-04-05 0:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404.182105.1576892492865932011.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=AdapterLinuxOpenSrcExtTeam@Brocade.COM \
--cc=huangj@Brocade.COM \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).