From: David Miller <davem@davemloft.net>
To: or.gerlitz@gmail.com
Cc: amirv@mellanox.com, netdev@vger.kernel.org,
yevgenyp@mellanox.com, john.r.fastabend@intel.com
Subject: Re: [PATCH net-next V6 7/8] net/dcb: Add an optional max rate attribute
Date: Wed, 04 Apr 2012 18:28:38 -0400 (EDT) [thread overview]
Message-ID: <20120404.182838.86622924907738367.davem@davemloft.net> (raw)
In-Reply-To: <CAJZOPZKDBECDx0_Yy7N12d8we92N-=0PAOryqOYmmiJ7n7Z1dQ@mail.gmail.com>
From: Or Gerlitz <or.gerlitz@gmail.com>
Date: Thu, 5 Apr 2012 01:27:29 +0300
> Or Gerlitz <or.gerlitz@gmail.com> wrote:
>> John Fastabend <john.r.fastabend@intel.com> wrote:
>>> And I think the last comment. We really should have a comment here describing
>>> what the tc_maxrate field is. Its described in the commit log but its much
>>> harder for implementers to get it wrong when the struct is annotated.
>
>> Okay, John, sure, we can add that, so just to make sure, from your
>> side the series is okay once this comment is added, correct?
>
> Also, Dave, any further comments from you on this series, or with
> adding that comment John was asking for - the patches are all fine?
Yep, they seem mostly fine to me. So please resubmit with the comment
fix.
next prev parent reply other threads:[~2012-04-04 22:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 10:57 [PATCH net-next V6 0/8] net/mlx4_en: DCB QoS support Amir Vadai
2012-04-04 10:57 ` [PATCH net-next V6 1/8] net/mlx4_en: Force user priority by QP attribute Amir Vadai
2012-04-04 10:57 ` [PATCH net-next V6 2/8] net/mlx4_core: set port QoS attributes Amir Vadai
2012-04-04 10:57 ` [PATCH net-next V6 3/8] net/mlx4_en: DCB QoS support Amir Vadai
2012-04-04 10:58 ` [PATCH net-next V6 4/8] net/mlx4_en: sk_prio <=> UP for untagged traffic Amir Vadai
2012-04-04 10:58 ` [PATCH net-next V6 5/8] net/route: export symbol ip_tos2prio Amir Vadai
2012-04-04 10:58 ` [PATCH net-next V6 6/8] IB/rdma_cm: TOS <=> UP mapping for IBoE Amir Vadai
2012-04-04 10:58 ` [PATCH net-next V6 7/8] net/dcb: Add an optional max rate attribute Amir Vadai
2012-04-04 15:48 ` John Fastabend
2012-04-04 21:56 ` Or Gerlitz
2012-04-04 22:27 ` Or Gerlitz
2012-04-04 22:28 ` David Miller [this message]
2012-04-04 22:30 ` Or Gerlitz
2012-04-05 0:23 ` John Fastabend
2012-04-05 0:39 ` Dave Taht
2012-04-04 10:58 ` [PATCH net-next V6 8/8] net/mlx4_en: Set max rate-limit for a TC Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404.182838.86622924907738367.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).