From: David Miller <davem@davemloft.net>
To: huangj@Brocade.COM
Cc: netdev@vger.kernel.org, AdapterLinuxOpenSrcExtTeam@Brocade.COM
Subject: Re: [PATCH 0/7] bna: Update driver version to 3.0.23.0 (resubmit)
Date: Wed, 04 Apr 2012 20:15:45 -0400 (EDT) [thread overview]
Message-ID: <20120404.201545.244323096520849467.davem@davemloft.net> (raw)
In-Reply-To: <E5313AF6F2BFD14293E5FD0F94750F86B3A74DEE55@HQ1-EXCH01.corp.brocade.com>
From: Jing Huang <huangj@Brocade.COM>
Date: Wed, 4 Apr 2012 16:07:22 -0700
> The ioc init semaphore register is only used by driver. Firmware
> will never touch this register. It will only be set to 1 when there
> is a driver instance holding it. So in practice, the infinite look
> will happen only if a driver instance grab the semaphore but forgot
> to release it. We add this logic to serialize register access for
> potential case of concurrent PCI function probe, which seems pretty
> rare in Linux.
Thanks for the clarification.
> I agree that this code looks ugly and wrong in theory. We will consider remove it or
> implement some timeout logic for it.
Ok, great.
prev parent reply other threads:[~2012-04-05 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 15:41 [PATCH 0/7] bna: Update driver version to 3.0.23.0 (resubmit) Jing Huang
2012-04-04 22:21 ` David Miller
2012-04-04 23:07 ` Jing Huang
2012-04-05 0:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404.201545.244323096520849467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=AdapterLinuxOpenSrcExtTeam@Brocade.COM \
--cc=huangj@Brocade.COM \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).