netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: cascardo@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, roland@kernel.org, ogerlitz@mellanox.com,
	yevgenyp@mellanox.co.il, alexg@mellanox.co.il,
	klebers@linux.vnet.ibm.com
Subject: Re: [PATCH] mlx4: allocate just enough pages instead of always 4 pages
Date: Wed, 04 Apr 2012 20:34:48 -0400 (EDT)	[thread overview]
Message-ID: <20120404.203448.1118889674233934663.davem@davemloft.net> (raw)
In-Reply-To: <1333568440-14494-1-git-send-email-cascardo@linux.vnet.ibm.com>

From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Date: Wed,  4 Apr 2012 16:40:40 -0300

> The driver uses a 2-order allocation, which is too much on architectures
> like ppc64, which has a 64KiB page. This particular allocation is used
> for large packet fragments that may have a size of 512, 1024, 4096 or
> fill the whole allocation. So, a minimum size of 16384 is good enough
> and will be the same size that is used in architectures of 4KiB sized
> pages.
> 
> This will avoid allocation failures that we see when the system is under
> stress, but still has plenty of memory, like the one below.
> 
> This will also allow us to set the interface MTU to higher values like
> 9000, which was not possible on ppc64 without this patch.
 ...
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
> Signed-off-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
> Tested-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>

Applied, thanks a lot.

      reply	other threads:[~2012-04-05  0:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-04 19:40 [PATCH] mlx4: allocate just enough pages instead of always 4 pages Thadeu Lima de Souza Cascardo
2012-04-05  0:34 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120404.203448.1118889674233934663.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexg@mellanox.co.il \
    --cc=cascardo@linux.vnet.ibm.com \
    --cc=klebers@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=roland@kernel.org \
    --cc=yevgenyp@mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).