From: David Miller <davem@davemloft.net>
To: raise.sail@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rps: introduce a new sysctl switch rps_workaround_buggy_driver
Date: Thu, 05 Apr 2012 06:44:12 -0400 (EDT) [thread overview]
Message-ID: <20120405.064412.2145338934095035978.davem@davemloft.net> (raw)
In-Reply-To: <4F7D7464.7040503@gmail.com>
From: Li Yu <raise.sail@gmail.com>
Date: Thu, 05 Apr 2012 18:31:00 +0800
>
> We encountered a buggy NIC driver or hardware/firmware, it keeps
> non-zero constant skb->rxhash for long time, so if we enabled RPS,
> the targeted CPU keeps same for long time too.
>
> This patch introduces a sysctl switch to workaround for such problem,
> if the switch was on, RPS core discards the skb->rxhash that is
> computed by NIC hardware.
>
> Hope this patch also can help others, thanks.
>
> Signed-off-by Li Yu <bingtian.ly@taobao.com>
No way, we fix the drivers not add workarounds like this.
next prev parent reply other threads:[~2012-04-05 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 10:31 [PATCH net-next] rps: introduce a new sysctl switch rps_workaround_buggy_driver Li Yu
2012-04-05 10:44 ` David Miller [this message]
2012-04-05 11:07 ` Eric Dumazet
2012-04-06 2:07 ` Li Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405.064412.2145338934095035978.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=raise.sail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).