From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: arvid.brodin@enea.com, shemminger@vyatta.com,
netdev@vger.kernel.org, balferreira@googlemail.com,
arvid.brodin@xdin.com
Subject: Re: [RFC] net/hsr: Add support for IEC 62439-3 High-availability Seamless Redundancy
Date: Thu, 05 Apr 2012 18:31:43 -0400 (EDT) [thread overview]
Message-ID: <20120405.183143.727226239038853914.davem@davemloft.net> (raw)
In-Reply-To: <1333653668.2652.13.camel@bwh-desktop.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 5 Apr 2012 20:21:08 +0100
> On Wed, 2012-04-04 at 20:17 -0400, David Miller wrote:
>> From: Arvid Brodin <arvid.brodin@enea.com>
>> Date: Thu, 5 Apr 2012 01:09:48 +0200
>>
>> > - icmp_param.data.icmph = *icmp_hdr(skb);
>> > + memcpy(&icmp_param.data.icmph, icmp_hdr(skb),
>> > + sizeof(icmp_param.data.icmph));
>>
>> GCC can and will optimize this into an inline assignment, and thus
>> have the same unaligned access problems, because it determines
>> alignment based upon the types involved.
>
> So presumably icmp_hdr() should be changed to skb_transport_header().
I would not say so. Otherwise we introduce ugly casts everywhere.
next prev parent reply other threads:[~2012-04-05 22:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 13:20 [RFC] net/hsr: Add support for IEC 62439-3 High-availability Seamless Redundancy Arvid Brodin
2012-04-03 18:37 ` Stephen Hemminger
2012-04-04 23:09 ` Arvid Brodin
2012-04-04 23:55 ` Stephen Hemminger
2012-04-05 0:21 ` David Miller
2012-04-06 15:51 ` Arvid Brodin
2012-04-06 16:43 ` David Miller
2012-04-06 17:08 ` Arvid Brodin
2012-04-06 17:06 ` Ben Hutchings
2012-04-06 18:19 ` Stephen Hemminger
2012-04-11 0:00 ` Arvid Brodin
2012-04-11 1:28 ` Stephen Hemminger
2012-04-11 14:39 ` Arvid Brodin
2012-04-05 0:17 ` David Miller
2012-04-05 19:21 ` Ben Hutchings
2012-04-05 22:31 ` David Miller [this message]
2012-05-14 18:11 ` Arvid Brodin
2012-05-14 18:28 ` Stephen Hemminger
2012-05-24 17:09 ` Arvid Brodin
2012-05-24 17:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405.183143.727226239038853914.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arvid.brodin@enea.com \
--cc=arvid.brodin@xdin.com \
--cc=balferreira@googlemail.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).