From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Balbir Singh
<bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 2/2] cgroup: get rid of populate for memcg
Date: Mon, 9 Apr 2012 11:13:31 -0700 [thread overview]
Message-ID: <20120409181331.GD7522@google.com> (raw)
In-Reply-To: <4F83218E.7060502-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Hello,
On Mon, Apr 09, 2012 at 02:51:10PM -0300, Glauber Costa wrote:
> On 04/09/2012 02:40 PM, Tejun Heo wrote:
> >which BTW seems incorrect even on its
> >own - unmounting and mounting again would probably make the same
> >notifier registered multiple times corrupting notification chain, and
> >ref inc on the parent.
>
>
> For the maintainers: Should I fix those in a new submission, or do
> you intend to do it yourselves?
>
> the refcnt dropping should probably be done in my patch, it is a new
> leak (sorry). The hotplug notifier, as tejun pointed, was already
> there.
>
> It seems simple enough to fix, so if you guys want, I can bundle it in
> a new submission.
I think it would be best to create a separate patch which is routed
through the usual memcg path (I suppose memcg patches go through
-mm?).
Thanks.
--
tejun
next prev parent reply other threads:[~2012-04-09 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 16:04 [PATCH v2 0/2] update memcg to break its need of populate Glauber Costa
[not found] ` <1333728250-14248-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-04-06 16:04 ` [PATCH v2 1/2] cgroup: pass struct mem_cgroup instead of struct cgroup to socket memcg Glauber Costa
2012-04-06 16:04 ` [PATCH v2 2/2] cgroup: get rid of populate for memcg Glauber Costa
[not found] ` <1333728250-14248-3-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-04-09 17:40 ` Tejun Heo
[not found] ` <20120409174042.GA7522-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-09 17:51 ` Glauber Costa
[not found] ` <4F83218E.7060502-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-04-09 18:13 ` Tejun Heo [this message]
[not found] ` <20120409181331.GD7522-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-09 20:18 ` Glauber Costa
[not found] ` <4F83442C.8040006-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-04-09 20:39 ` Tejun Heo
2012-04-10 1:37 ` KAMEZAWA Hiroyuki
2012-04-10 1:35 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120409181331.GD7522@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).