From: Dan Carpenter <dan.carpenter@oracle.com>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: anirban.chakraborty@qlogic.com, rajesh.borundia@qlogic.com,
sony.chacko@qlogic.com, linux-driver@qlogic.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] qlcnic: Remove redundant NULL check on kfree().
Date: Tue, 10 Apr 2012 10:49:59 +0300 [thread overview]
Message-ID: <20120410074959.GA4393@mwanda> (raw)
In-Reply-To: <1333951879-3230-1-git-send-email-santoshprasadnayak@gmail.com>
On Mon, Apr 09, 2012 at 11:41:19AM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> kfree() checks for NULL before freeing the memory.
> Remove redundant NULL check.
> This is just a clean up and also looks good from performance point of view.
I doubt it has any impact on performance.
[snip]
> static void qlcnic_free_lb_filters_mem(struct qlcnic_adapter *adapter)
> {
> - if (adapter->fhash.fmax && adapter->fhash.fhead)
> - kfree(adapter->fhash.fhead);
> -
> + kfree(adapter->fhash.fhead);
This changes how the code works. That's very sloppy to not notice
that. If you did notice it, it should be justified in the
changelog. :(
> adapter->fhash.fhead = NULL;
> adapter->fhash.fmax = 0;
> }
regards,
dan carpenter
prev parent reply other threads:[~2012-04-10 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 6:11 [PATCH 2/2] qlcnic: Remove redundant NULL check on kfree() santosh nayak
2012-04-10 7:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410074959.GA4393@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
--cc=santoshprasadnayak@gmail.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).