netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Arvid Brodin <Arvid.Brodin@xdin.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
	David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"balferreira@googlemail.com" <balferreira@googlemail.com>
Subject: Re: [RFC] net/hsr: Add support for IEC 62439-3 High-availability Seamless Redundancy
Date: Tue, 10 Apr 2012 18:28:47 -0700	[thread overview]
Message-ID: <20120410182847.45e47c5e@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <4F84CA36.7020209@xdin.com>


> 3) My feeble suggestion to cast icmp_hdr() to (char *) is of course even worse (it doesn't
> even avoid the erroneous cast in the first place).
> 
> So what do we do?
> 

Reading Documentation/unalgined-memory-access.txt suggests that you
probably should copy the skb before passing up the stack (if necessary).
That is safe (but slightly slower).

  reply	other threads:[~2012-04-11  1:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 13:20 [RFC] net/hsr: Add support for IEC 62439-3 High-availability Seamless Redundancy Arvid Brodin
2012-04-03 18:37 ` Stephen Hemminger
2012-04-04 23:09   ` Arvid Brodin
2012-04-04 23:55     ` Stephen Hemminger
2012-04-05  0:21       ` David Miller
2012-04-06 15:51         ` Arvid Brodin
2012-04-06 16:43           ` David Miller
2012-04-06 17:08             ` Arvid Brodin
2012-04-06 17:06           ` Ben Hutchings
2012-04-06 18:19             ` Stephen Hemminger
2012-04-11  0:00               ` Arvid Brodin
2012-04-11  1:28                 ` Stephen Hemminger [this message]
2012-04-11 14:39                   ` Arvid Brodin
2012-04-05  0:17     ` David Miller
2012-04-05 19:21       ` Ben Hutchings
2012-04-05 22:31         ` David Miller
2012-05-14 18:11 ` Arvid Brodin
2012-05-14 18:28   ` Stephen Hemminger
2012-05-24 17:09     ` Arvid Brodin
2012-05-24 17:16       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120410182847.45e47c5e@nehalam.linuxnetplumber.net \
    --to=shemminger@vyatta.com \
    --cc=Arvid.Brodin@xdin.com \
    --cc=balferreira@googlemail.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).