From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rtnetlink & bonding: change args got get_tx_queues
Date: Wed, 11 Apr 2012 08:20:54 -0700 [thread overview]
Message-ID: <20120411082054.2bf6a352@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1334123747.5300.2197.camel@edumazet-glaptop>
On Wed, 11 Apr 2012 07:55:47 +0200
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Tue, 2012-04-10 at 21:34 -0700, Stephen Hemminger wrote:
> > Change get_tx_queues, drop unsused arg/return value real_tx_queues,
> > and use return by value (with error) rather than call by reference.
> >
> > Probably bonding should just change to LLTX and the whole get_tx_queues
> > API could disappear!
>
> Absolutely ;)
>
>
It is more complex than that (actually the bonding driver is a mess).
The bonding device is already using Lockless Transmit and transmit queue length
of zero (good), but it then does some queue mapping of it's own which
is unnecessary.
Multiqueue only makes sense if there is a queue, otherwise the skb
can transparently pass through the layered device (vlan, bridge, bond)
and get queued on the real physical device.
Right now, trying to see if there is any impact by just leaving
bond device as single queue.
next prev parent reply other threads:[~2012-04-11 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 20:27 [PATCH net-next] rtnetlink: fix spelling errors Stephen Hemminger
2012-04-09 22:09 ` Ben Hutchings
2012-04-11 4:32 ` [PATCH] rtnetlink: fix comments Stephen Hemminger
2012-04-13 17:33 ` David Miller
2012-04-11 4:34 ` [PATCH net-next] rtnetlink & bonding: change args got get_tx_queues Stephen Hemminger
2012-04-11 5:55 ` Eric Dumazet
2012-04-11 15:20 ` Stephen Hemminger [this message]
2012-04-11 18:13 ` Jay Vosburgh
2012-04-11 18:21 ` Stephen Hemminger
2012-04-13 17:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411082054.2bf6a352@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=andy@greyhouse.net \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).