From: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org
Subject: Re: pull request: batman-adv 2012-04-11
Date: Wed, 11 Apr 2012 16:31:03 +0200 [thread overview]
Message-ID: <20120411143102.GE19365@ritirata.org> (raw)
In-Reply-To: <20120411.095809.861355939666821335.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
On Wed, Apr 11, 2012 at 09:58:09 -0400, David Miller wrote:
> From: Antonio Quartulli <ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
> Date: Wed, 11 Apr 2012 15:03:03 +0200
>
> > git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem
> >
> > for you to fetch changes up to 7a5cc24277b57ce38eb0afa6634b71d4d5cc671e:
> >
> > batman-adv: add bridge loop avoidance compile option (2012-04-11 14:29:00 +0200)
>
> Pulled, but I think the way you're doing the bridge loop avoidance stuff
> is wrong.
>
> Don't use a Kconfig option, use a sysctl to turn the behavior off or on
> at runtime instead.
Hello David and thank you for your feedback.
Actually we have either the Kconfig option (for binary size purposes) AND a
boolean attribute in our soft_interface sysfs path (to dynamically turn the
bridge loop avoidance ON and OFF as you were suggesting).
Regards,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-04-11 14:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 12:50 pull request: batman-adv 2012-04-11 Antonio Quartulli
[not found] ` <1334148649-25443-1-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
2012-04-11 12:50 ` [PATCH 01/16] MAINTAINERS: add additional maintainer for net/batman-adv Antonio Quartulli
2012-04-11 12:50 ` [PATCH 02/16] batman-adv: clean up Kconfig Antonio Quartulli
2012-04-11 12:50 ` [PATCH 03/16] batman-adv: use ETH_ALEN instead of hardcoded numeric constants Antonio Quartulli
2012-04-11 12:50 ` [PATCH 04/16] batman-adv: Replace bitarray operations with bitmap Antonio Quartulli
2012-04-11 12:50 ` [PATCH 05/16] batman-adv: Remove declaration of only locally used functions Antonio Quartulli
2012-04-11 12:50 ` [PATCH 06/16] batman-adv: encourage batman to take shorter routes by changing the default hop penalty Antonio Quartulli
2012-04-11 12:50 ` [PATCH 07/16] batman-adv: remove old bridge loop avoidance code Antonio Quartulli
2012-04-11 12:50 ` [PATCH 08/16] batman-adv: add basic " Antonio Quartulli
2012-04-11 12:50 ` [PATCH 09/16] batman-adv: make bridge loop avoidance switchable Antonio Quartulli
2012-04-11 12:50 ` [PATCH 10/16] batman-adv: export claim tables through debugfs Antonio Quartulli
2012-04-11 12:50 ` [PATCH 11/16] batman-adv: allow multiple entries in tt_global_entries Antonio Quartulli
2012-04-11 12:50 ` [PATCH 12/16] batman-adv: don't let backbone gateways exchange tt entries Antonio Quartulli
2012-04-11 12:50 ` [PATCH 13/16] batman-adv: add broadcast duplicate check Antonio Quartulli
2012-04-11 12:50 ` [PATCH 14/16] batman-adv: drop STP over batman Antonio Quartulli
2012-04-11 12:50 ` [PATCH 15/16] batman-adv: form groups in the bridge loop avoidance Antonio Quartulli
2012-04-11 12:50 ` [PATCH 16/16] batman-adv: add bridge loop avoidance compile option Antonio Quartulli
2012-04-11 13:03 ` pull request: batman-adv 2012-04-11 Antonio Quartulli
[not found] ` <20120411130301.GD19365-E/2OGukznS5g9hUCZPvPmw@public.gmane.org>
2012-04-11 13:58 ` David Miller
[not found] ` <20120411.095809.861355939666821335.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-04-11 14:31 ` Antonio Quartulli [this message]
2012-04-11 14:39 ` [B.A.T.M.A.N.] " David Miller
[not found] ` <20120411.103933.846397076858317541.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-04-11 14:43 ` Gioacchino Mazzurco
[not found] ` <4F85989F.6030802-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-04-11 14:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411143102.GE19365@ritirata.org \
--to=ordex-gaufno9rbhfsroww+9zijq@public.gmane.org \
--cc=b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).