From: David Miller <davem@davemloft.net>
To: fbl@redhat.com
Cc: jasowang@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 8139cp: set intr mask after its handler is registered
Date: Fri, 13 Apr 2012 13:42:43 -0400 (EDT) [thread overview]
Message-ID: <20120413.134243.2000744517368456334.davem@davemloft.net> (raw)
In-Reply-To: <20120412104529.27ece685@asterix.rh>
From: Flavio Leitner <fbl@redhat.com>
Date: Thu, 12 Apr 2012 10:45:29 -0300
> On Thu, 12 Apr 2012 16:10:54 +0800
> Jason Wang <jasowang@redhat.com> wrote:
>
>> We set intr mask before its handler is registered, this does not work well when
>> 8139cp is sharing irq line with other devices. As the irq could be enabled by
>> the device before 8139cp's hander is registered which may lead unhandled
>> irq. Fix this by introducing an helper cp_irq_enable() and call it after
>> request_irq().
>>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> Reviewed-by: Flavio Leitner <fbl@redhat.com>
Applied, and queued up for -stable, thanks.
prev parent reply other threads:[~2012-04-13 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 8:10 [PATCH] 8139cp: set intr mask after its handler is registered Jason Wang
2012-04-12 13:45 ` Flavio Leitner
2012-04-13 17:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413.134243.2000744517368456334.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).