From: David Miller <davem@davemloft.net>
To: will.deacon@arm.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
steve.glendinning@smsc.com
Subject: Re: [PATCH] net: smsc911x: fix RX FIFO fastforwarding when dropping packets
Date: Fri, 13 Apr 2012 14:08:25 -0400 (EDT) [thread overview]
Message-ID: <20120413.140825.574220698055703201.davem@davemloft.net> (raw)
In-Reply-To: <20120412170350.GD28204@mudshark.cambridge.arm.com>
From: Will Deacon <will.deacon@arm.com>
Date: Thu, 12 Apr 2012 18:03:50 +0100
> On Thu, Apr 12, 2012 at 05:08:00PM +0100, Eric Dumazet wrote:
>> On Thu, 2012-04-12 at 16:54 +0100, Will Deacon wrote:
>> > net: smsc911x: fix skb handling in receive path
>> >
>> > The SMSC911x driver resets the ->head, ->data and ->tail pointers in the
>> > skb on the reset path in order to avoid buffer overflow due to packet
>> > padding performed by the hardware.
>> >
>> > This patch fixes the receive path so that the skb pointers are fixed up
>> > after the data has been read from the device, The error path is also
>> > fixed to use number of words consistently and prevent erroneous FIFO
>> > fastforwarding when skipping over bad data.
>> >
>> > Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> [...]
>
>> Seems fine to me
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Thanks, Eric. Given that Steve's email doesn't appear to be working, can
> somebody else pick this up please?
Applied, thanks.
prev parent reply other threads:[~2012-04-13 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 9:07 [PATCH] net: smsc911x: fix RX FIFO fastforwarding when dropping packets Will Deacon
2012-04-12 9:20 ` Eric Dumazet
2012-04-12 12:53 ` Will Deacon
2012-04-12 13:06 ` Eric Dumazet
2012-04-12 13:47 ` Will Deacon
2012-04-12 14:01 ` Eric Dumazet
2012-04-12 15:54 ` Will Deacon
2012-04-12 16:08 ` Eric Dumazet
2012-04-12 17:03 ` Will Deacon
2012-04-12 17:41 ` Eric Dumazet
2012-04-13 18:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413.140825.574220698055703201.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).