From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, shemminger@vyatta.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: suspicious RCU usage warnings in 3.3.0
Date: Fri, 13 Apr 2012 09:30:34 -0700 [thread overview]
Message-ID: <20120413163029.GA2402@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120413.105556.73360716787161031.davem@davemloft.net>
On Fri, Apr 13, 2012 at 10:55:56AM -0400, David Miller wrote:
> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Date: Fri, 13 Apr 2012 06:35:13 -0700
>
> DANGER WILL ROBINSON, McKenney is hacking sparc64 assembler!
> :-))))
;-) ;-) ;-)
> > My main concern about my patch is my removal of this line:
> >
> > bne,pn %icc, __handle_softirq
> >
> > It is quite possible that this should instead change to look as follows:
> >
> > bne,pn %icc, __handle_preemption
> >
>
> I would say it should not, because the __handle_softirq code path,
> if taken, unconditionally branches to the very next instruction
> after this branch and it's delay slot.
Beginners luck beats skill. Now I just have to be very careful to
avoid ever submitting a second sparc64 assembler patch. ;-)
> > Anyway, patch with updated changelog below.
>
> Great work, I'll apply this after I test it out a bit myself.
Cool!!!
Thanx, Paul
> Thanks a lot Paul!
>
prev parent reply other threads:[~2012-04-13 16:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 8:45 suspicious RCU usage warnings in 3.3.0 Meelis Roos
2012-03-28 21:45 ` David Miller
2012-04-11 15:08 ` Meelis Roos
2012-04-11 23:08 ` Paul E. McKenney
2012-04-12 0:10 ` Stephen Hemminger
2012-04-12 0:18 ` David Miller
2012-04-12 0:45 ` Paul E. McKenney
2012-04-12 1:03 ` David Miller
2012-04-12 1:53 ` Paul E. McKenney
2012-04-12 1:08 ` David Miller
2012-04-12 4:54 ` Paul E. McKenney
2012-04-13 11:55 ` mroos
2012-04-13 13:35 ` Paul E. McKenney
2012-04-13 14:55 ` David Miller
2012-04-13 16:30 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413163029.GA2402@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).