From: David Miller <davem@davemloft.net>
To: xiong@qca.qualcomm.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
qca-linux-team@qualcomm.com, nic-devel@qualcomm.com
Subject: Re: [PATCH 04/12] atl1c: remove VPD register
Date: Sat, 14 Apr 2012 14:43:05 -0400 (EDT) [thread overview]
Message-ID: <20120414.144305.2085076886038926579.davem@davemloft.net> (raw)
In-Reply-To: <1334397568-8444-5-git-send-email-xiong@qca.qualcomm.com>
From: xiong <xiong@qca.qualcomm.com>
Date: Sat, 14 Apr 2012 17:59:20 +0800
> VPD register is only used for L1(devid=PCI_DEVICE_ID_ATTANSIC_L1) to
> access external NV-memory.
> l1c & later chip doesn't use it any more.
> no special userspace tool interpret the dumpped registers.
> dumpping them via ethtool is just for debug.
>
> Signed-off-by: xiong <xiong@qca.qualcomm.com>
> Tested-by: Liu David <dwliu@qca.qualcomm.com>
I'm really disappointed that you're posting this patch again and
completely ignoring our feedback.
You're making this code buggy, and you're make me extremely irritated.
What's the point of our feedback if you just completely ignore it?
You can't crap up the register dump like this, you have to make
several modifications if you want to change the layout in any
way:
1) You have to adjust AT_REGS_LEN, because you're reporting one
less register.
2) You have to adjust the offsets at the end of atl1c_get_regs(),
the ones that explicitly use regs_buff[73] and regs_buf[74],
otherwise you're leaving a gap between that area that's filled
in using those p++ pointer increments and the entries filled
in with these explicit offsets into reg_buff[].
3) You have to increment the register dump version, via the struct
ethtool_regs 'version' field, so that userland programs can know
that you've changed it.
So, tell me, are you going to completely ignore our feedback on
this issue again?
next prev parent reply other threads:[~2012-04-14 18:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 9:59 [PATCH 00/12] atl1c: update hardware settings -v1 xiong
2012-04-14 9:59 ` [PATCH 01/12] atl1c: update author contact info & company/driver desciption xiong
2012-04-14 9:59 ` [PATCH 02/12] atl1c: remove multiple-RX-Q code xiong
2012-04-14 9:59 ` [PATCH 03/12] atl1c: remove HDS register xiong
2012-04-14 9:59 ` [PATCH 04/12] atl1c: remove VPD register xiong
2012-04-14 18:43 ` David Miller [this message]
2012-04-14 9:59 ` [PATCH 05/12] atl1c: remove SMB/CMB DMA related code xiong
2012-04-14 9:59 ` [PATCH 06/12] atl1c: split 2 32bit registers of TPD to 4 16bit registers xiong
2012-04-14 9:59 ` [PATCH 07/12] atl1c: remove code related to rxq 1/2/3 xiong
2012-04-14 9:59 ` [PATCH 08/12] atl1c: wrong register used to stop TXQ xiong
2012-04-14 9:59 ` [PATCH 09/12] atl1c: correct wrong definition of REG_DMA_CTRL xiong
2012-04-14 9:59 ` [PATCH 10/12] atl1c: remove dmaw_block xiong
2012-04-14 9:59 ` [PATCH 11/12] atl1c: using fixed TXQ configuration for l2cb and l1c xiong
2012-04-14 9:59 ` [PATCH 12/12] atl1c: restore max-read-request-size in Device Conrol Register xiong
2012-04-14 18:43 ` [PATCH 00/12] atl1c: update hardware settings -v1 David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-04-18 5:32 [PATCH 00/12] atl1c: update hardware settings - v1 xiong
2012-04-18 5:32 ` [PATCH 04/12] atl1c: remove VPD register xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120414.144305.2085076886038926579.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=qca-linux-team@qualcomm.com \
--cc=xiong@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).