From: Michal Kubecek <mkubecek@suse.cz>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Flavio Leitner <fbl@redhat.com>,
netdev@vger.kernel.org, Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [PATCH] bonding: start slaves with link down for ARP monitor
Date: Sat, 14 Apr 2012 21:25:54 +0200 [thread overview]
Message-ID: <20120414192554.GB8424@lion.mk-sys.cz> (raw)
In-Reply-To: <9048.1334380877@death.nxdomain>
On Fri, Apr 13, 2012 at 10:21:17PM -0700, Jay Vosburgh wrote:
>
> The functional part I'm not sure about yet is if the this will
> cause slave devices with fast autoneg to wait for an ARP monitor cycle
> before going link up according to ARP monitor.
>
> I think this may work better if the initial slave state is set
> to whatever netif_carrier_ok() says, instead of unconditionally up or
> down.
This would mean the initial state would be always up for drivers not
supporting netif_carrier_ok(). But as far as I can see, only a few such
drivers are left and they are not very frequent ones. So I agree it will
be less harm to keep starting with up link state for these drivers than
to introduce an unnecessary delay for cards/driver which are fast enough.
I'll send updated version of the patch after I test it.
Michal Kubecek
next prev parent reply other threads:[~2012-04-14 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 18:38 [PATCH] bonding: start slaves with link down for ARP monitor Michal Kubecek
2012-04-14 4:53 ` Flavio Leitner
2012-04-14 5:21 ` Jay Vosburgh
2012-04-14 19:25 ` Michal Kubecek [this message]
2012-04-14 19:09 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120414192554.GB8424@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=andy@greyhouse.net \
--cc=fbl@redhat.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).