From: David Miller <davem@davemloft.net>
To: dbaluta@ixiacom.com
Cc: netdev@vger.kernel.org, trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][trivial] ipv4: fix checkpatch errors
Date: Sun, 15 Apr 2012 12:38:51 -0400 (EDT) [thread overview]
Message-ID: <20120415.123851.786816332832233291.davem@davemloft.net> (raw)
In-Reply-To: <1334489681-4662-1-git-send-email-dbaluta@ixiacom.com>
From: dbaluta@ixiacom.com
Date: Sun, 15 Apr 2012 14:34:41 +0300
> From: Daniel Baluta <dbaluta@ixiacom.com>
>
> Fix checkpatch errors of the following type:
> * ERROR: "foo * bar" should be "foo *bar"
> * ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>
Applied, but:
> @@ -216,7 +216,7 @@ static struct rtnl_link_stats64 *ipgre_get_stats64(struct net_device *dev,
>
> /* Given src, dst and key, find appropriate for input tunnel. */
>
> -static struct ip_tunnel * ipgre_tunnel_lookup(struct net_device *dev,
> +static struct ip_tunnel *ipgre_tunnel_lookup(struct net_device *dev,
> __be32 remote, __be32 local,
> __be32 key, __be16 gre_proto)
> {
I had to reindent these function arguments on the lines after the one
you modified so that they continue to line up properly with the column
of the openning parenthesis on the previous line.
Do not blindly make checkpatch fixes without taking into consideration
the indentation modifications necessary in the context around your
change.
prev parent reply other threads:[~2012-04-15 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 11:34 [PATCH][trivial] ipv4: fix checkpatch errors dbaluta
2012-04-15 16:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120415.123851.786816332832233291.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dbaluta@ixiacom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).