netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.hengli.com.au
Cc: netdev@vger.kernel.org
Subject: Re: [0/3] bridge: Do not send multicast queries by default
Date: Sun, 15 Apr 2012 12:52:25 -0400 (EDT)	[thread overview]
Message-ID: <20120415.125225.1400564852542689459.davem@davemloft.net> (raw)
In-Reply-To: <20120413123641.GA758@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.hengli.com.au>
Date: Fri, 13 Apr 2012 20:36:41 +0800

> This series of patches is aimed to change the default multicast
> snooping behaviour to one that is safer to deploy in the wild.
> 
> There have been numerous reports of switches misbehaving with
> our current behaviour of sending general queries, presumably
> because we're using a zero source IP address which is unavoidable
> as using anything else would interfere with multicast querier
> elections (incidentally, I noticed that our IPv6 code has been
> "fixed" to not use zero source addresses, which is wrong as we
> may end up being THE MLD querier in a network).
> 
> Since our queries aren't actually required for multicast snooping
> to function, but is merely an optimisation mostly for faster
> start-up convergence, I think we should disable this by default.

All applied to net-next, thanks Herbert.

      parent reply	other threads:[~2012-04-15 16:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 12:36 [0/3] bridge: Do not send multicast queries by default Herbert Xu
2012-04-13 12:37 ` [PATCH 2/3] bridge: Restart queries when last querier expires Herbert Xu
2012-04-13 12:37 ` [PATCH 3/3] bridge: Add multicast_querier toggle and disable queries by default Herbert Xu
2012-04-13 12:37 ` [PATCH 1/3] bridge: Add br_multicast_start_querier Herbert Xu
2012-04-13 14:53 ` [0/3] bridge: Do not send multicast queries by default David Miller
2012-04-15 11:13   ` Herbert Xu
2012-04-15 16:50     ` David Miller
2013-04-03 15:28     ` Linus Lüssing
2012-04-15 16:52 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120415.125225.1400564852542689459.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).