From: David Miller <davem@davemloft.net>
To: antonz@parallels.com
Cc: netdev@vger.kernel.org, jcliburn@gmail.com, csnook@redhat.com,
khorenko@parallels.com
Subject: Re: [PATCH 0/9] atl1: add napi to Atheros L1 NIC
Date: Sun, 15 Apr 2012 13:28:05 -0400 (EDT) [thread overview]
Message-ID: <20120415.132805.143754486571031578.davem@davemloft.net> (raw)
In-Reply-To: <20120415.130346.1822341707659142562.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 15 Apr 2012 13:03:46 -0400 (EDT)
> From: Tony Zelenoff <antonz@parallels.com>
> Date: Fri, 13 Apr 2012 20:09:45 +0400
>
>> Added NAPI interface to the driver of Atheros L1 NIC.
>> RX speed reported by iperf in TCP mode (with and without -N
>> switch) improved by ~7 Mbps. In UDP mode the speed up is
>> improved by ~4 Mbps.
>> Also hard RX/TX rings processing with memory allocation in
>> interrupt handlers is not very good idea. So, fixed this.
>>
>> Note: thouse patches must be applied after patch, that fix
>> kernel panic in this driver.
>> Its subject is: "atl1: fix kernel panic in case of DMA errors"
>
> Unfortunately this is bullshit. These patches actually depend upon
> that bug fix not being applied. Look at the patches, they reference
> and use the reset workqueue the bug fix removed.
My bad, I thought I had merged the net tree into net-next before
processing your patches but I didn't.
I just fixed this all up in the net-next tree, please double
check my work.
Thank you.
next prev parent reply other threads:[~2012-04-15 17:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 16:09 [PATCH 0/9] atl1: add napi to Atheros L1 NIC Tony Zelenoff
2012-04-13 16:09 ` [PATCH 1/9] atl1: handle rx in separate condition Tony Zelenoff
2012-04-13 16:09 ` [PATCH 2/9] atl1: make driver napi compatible Tony Zelenoff
2012-04-13 17:15 ` Ben Hutchings
2012-04-13 19:22 ` David Miller
2012-04-13 16:09 ` [PATCH 3/9] atl1: add napi process of tx interrupts Tony Zelenoff
2012-04-13 16:09 ` [PATCH 4/9] atl1: use defined functions to disable irq Tony Zelenoff
2012-04-13 16:09 ` [PATCH 5/9] atl1: make function to set imr of card Tony Zelenoff
2012-04-13 16:09 ` [PATCH 6/9] atl1: add value to check ability of reenabling IRQs Tony Zelenoff
2012-04-13 16:09 ` [PATCH 7/9] atl1: enable errors and link ints when rx/tx scheduled Tony Zelenoff
2012-04-13 16:09 ` [PATCH 8/9] atl1: do not process interrupts in cycle in handler Tony Zelenoff
2012-04-13 16:09 ` [PATCH 9/9] atl1: do not drop rx/tx interrupts before they are scheduled Tony Zelenoff
2012-04-15 17:03 ` [PATCH 0/9] atl1: add napi to Atheros L1 NIC David Miller
2012-04-15 17:28 ` David Miller [this message]
2012-04-16 7:22 ` Tony Zelenoff
2012-04-16 18:20 ` David Miller
2012-04-16 20:51 ` Chris Snook
2012-04-17 8:42 ` Tony Zelenoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120415.132805.143754486571031578.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=antonz@parallels.com \
--cc=csnook@redhat.com \
--cc=jcliburn@gmail.com \
--cc=khorenko@parallels.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).