From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: netdev@vger.kernel.org, amirv@mellanox.com
Subject: Re: [PATCH net-next] drivers/net: fix unresolved 64bit math in mellanox/mlx4/en_dcb_nl.c
Date: Sun, 15 Apr 2012 23:31:39 -0400 (EDT) [thread overview]
Message-ID: <20120415.233139.452372897242947075.davem@davemloft.net> (raw)
In-Reply-To: <1334545794-16703-1-git-send-email-paul.gortmaker@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Sun, 15 Apr 2012 23:09:54 -0400
> Commit 109d2446052a484c58f07f71f9457bf7b71017f8
>
> "net/mlx4_en: Set max rate-limit for a TC"
>
> introduced 64 bit math operations into mlx4_en_dcbnl_ieee_setmaxrate()
>
> causing the following final link failure on an x86_32 allmodconfig
>
> ERROR: "__udivdi3" [drivers/net/ethernet/mellanox/mlx4/mlx4_en.ko] undefined!
>
> Convert it to use div_u64() instead.
>
> Cc: Amir Vadai <amirv@mellanox.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Please add an explicit linux/math64.h include here too, thanks.
next prev parent reply other threads:[~2012-04-16 3:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 3:09 [PATCH net-next] drivers/net: fix unresolved 64bit math in mellanox/mlx4/en_dcb_nl.c Paul Gortmaker
2012-04-16 3:31 ` David Miller [this message]
2012-04-16 4:17 ` [PATCH v2 " Paul Gortmaker
2012-04-16 6:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120415.233139.452372897242947075.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).