From: David Miller <davem@davemloft.net>
To: shimoda.hiroaki@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] dummy: Add ndo_uninit().
Date: Mon, 16 Apr 2012 23:57:00 -0400 (EDT) [thread overview]
Message-ID: <20120416.235700.92011132488911415.davem@davemloft.net> (raw)
In-Reply-To: <20120416082601.ac00a86d.shimoda.hiroaki@gmail.com>
From: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Date: Mon, 16 Apr 2012 08:26:01 +0900
> In register_netdevice(), when ndo_init() is successful and later
> some error occurred, ndo_uninit() will be called.
> So dummy deivce is desirable to implement ndo_uninit() method
> to free percpu stats for this case.
> And, ndo_uninit() is also called along with dev->destructor() when
> device is unregistered, so in order to prevent dev->dstats from
> being freed twice, dev->destructor is modified to free_netdev().
>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2012-04-17 3:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 23:26 [PATCH net] dummy: Add ndo_uninit() Hiroaki SHIMODA
2012-04-17 3:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416.235700.92011132488911415.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shimoda.hiroaki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).