From: David Miller <davem@davemloft.net>
To: jkosina@suse.cz
Cc: sdyoung@vt220.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] arcnet: rimi: Fix device name in debug output
Date: Tue, 17 Apr 2012 22:24:14 -0400 (EDT) [thread overview]
Message-ID: <20120417.222414.1021293399100195501.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1204161335420.16373@pobox.suse.cz>
From: Jiri Kosina <jkosina@suse.cz>
Date: Mon, 16 Apr 2012 14:02:48 +0200 (CEST)
> From: Jiri Kosina <jkosina@suse.cz>
> Subject: [PATCH] arcnet: rimi: Fix device name in debug output
>
> arcrimi_probe() calls BUGMSG() before register_netdev() happens. BUGMSG()
> itself prints dev->name, but as the format string hasn't been expanded by
> register_netdev() yet, the output contains bogus device name such as
>
> arc%d: Given: node 00h, shmem 0h, irq 0
>
> As we don't know the device name yet, just drop the prefix completely from
> the debugging messages.
>
> Reported-by: Steven Young <sdyoung@vt220.org>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Applied, thanks.
prev parent reply other threads:[~2012-04-18 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120415153220.GA11631@vt220.org>
2012-04-16 12:02 ` [PATCH] arcnet: rimi: Fix device name in debug output Jiri Kosina
2012-04-16 12:20 ` Steven Young
2012-04-18 2:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417.222414.1021293399100195501.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdyoung@vt220.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).