From: David Miller <davem@davemloft.net>
To: christian.riesch@omicron.at
Cc: netdev@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com,
ravonereal@gmail.com, manfred.rudigier@omicron.at,
stable@vger.kernel.org, cyril@ti.com
Subject: Re: [PATCH] davinci_mdio: Fix MDIO timeout check
Date: Tue, 17 Apr 2012 22:32:59 -0400 (EDT) [thread overview]
Message-ID: <20120417.223259.2096595530447053760.davem@davemloft.net> (raw)
In-Reply-To: <1334586925-11348-1-git-send-email-christian.riesch@omicron.at>
From: Christian Riesch <christian.riesch@omicron.at>
Date: Mon, 16 Apr 2012 16:35:25 +0200
> Under heavy load (flood ping) it is possible for the MDIO timeout to
> expire before the loop checks the GO bit again. This patch adds an
> additional check whether the operation was done before actually
> returning -ETIMEDOUT.
>
> To reproduce this bug, flood ping the device, e.g., ping -f -l 1000
> After some time, a "timed out waiting for user access" warning
> may appear. And even worse, link may go down since the PHY reported a
> timeout.
>
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> Cc: <stable@vger.kernel.org>
> Cc: Cyril Chemparathy <cyril@ti.com>
Applied.
prev parent reply other threads:[~2012-04-18 2:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 14:35 [PATCH] davinci_mdio: Fix MDIO timeout check Christian Riesch
2012-04-18 2:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417.223259.2096595530447053760.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christian.riesch@omicron.at \
--cc=cyril@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=manfred.rudigier@omicron.at \
--cc=netdev@vger.kernel.org \
--cc=ravonereal@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).