* [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak
@ 2012-04-17 1:41 majianpeng
2012-04-17 5:18 ` Eric Dumazet
0 siblings, 1 reply; 6+ messages in thread
From: majianpeng @ 2012-04-17 1:41 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
>From 582ed93b990e88110287ed0388bcb9057b1b8591 Mon Sep 17 00:00:00 2001
From: majianpeng <majianpeng@gmail.com>
Date: Tue, 17 Apr 2012 09:36:26 +0800
Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
Signed-off-by: majianpeng <majianpeng@gmail.com>
---
net/ipv4/route.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 167ea10..1984c82 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -3504,7 +3504,11 @@ int __init ip_rt_init(void)
* this nonsense will go away.
*/
void __init ip_static_sysctl_init(void)
-{
- register_sysctl_paths(ipv4_path, ipv4_skeleton);
+{
+ struct ctl_table_header *ctl_header;
+
+ ctl_header = register_sysctl_paths(ipv4_path, ipv4_skeleton);
+ if (ctl_header)
+ kmemleak_not_leak(ctl_header);
}
#endif
--
1.7.5.4
--------------
majianpeng
2012-04-17
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak
2012-04-17 1:41 [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak majianpeng
@ 2012-04-17 5:18 ` Eric Dumazet
2012-04-17 5:22 ` Re: [PATCH] net/ipv4:Remove two memleak reports bykmemeleak_not_leak majianpeng
0 siblings, 1 reply; 6+ messages in thread
From: Eric Dumazet @ 2012-04-17 5:18 UTC (permalink / raw)
To: majianpeng; +Cc: netdev
On Tue, 2012-04-17 at 09:41 +0800, majianpeng wrote:
> From 582ed93b990e88110287ed0388bcb9057b1b8591 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 17 Apr 2012 09:36:26 +0800
> Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
> net/ipv4/route.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 167ea10..1984c82 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -3504,7 +3504,11 @@ int __init ip_rt_init(void)
> * this nonsense will go away.
> */
> void __init ip_static_sysctl_init(void)
> -{
> - register_sysctl_paths(ipv4_path, ipv4_skeleton);
> +{
> + struct ctl_table_header *ctl_header;
> +
> + ctl_header = register_sysctl_paths(ipv4_path, ipv4_skeleton);
> + if (ctl_header)
> + kmemleak_not_leak(ctl_header);
> }
> #endif
No need for this temp var and conditional.
Just :
kmemleak_not_leak(register_sysctl_paths(ipv4_path, ipv4_skeleton));
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [PATCH] net/ipv4:Remove two memleak reports bykmemeleak_not_leak
2012-04-17 5:18 ` Eric Dumazet
@ 2012-04-17 5:22 ` majianpeng
0 siblings, 0 replies; 6+ messages in thread
From: majianpeng @ 2012-04-17 5:22 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev
Thanks,I will correct it and resent the patch.
------------------
majianpeng
2012-04-17
-------------------------------------------------------------
发件人：Eric Dumazet
发送日期：2012-04-17 13:18:54
收件人：majianpeng
抄送：netdev
主题：Re: [PATCH] net/ipv4:Remove two memleak reports bykmemeleak_not_leak
On Tue, 2012-04-17 at 09:41 +0800, majianpeng wrote:
> From 582ed93b990e88110287ed0388bcb9057b1b8591 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 17 Apr 2012 09:36:26 +0800
> Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
> net/ipv4/route.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 167ea10..1984c82 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -3504,7 +3504,11 @@ int __init ip_rt_init(void)
> * this nonsense will go away.
> */
> void __init ip_static_sysctl_init(void)
> -{
> - register_sysctl_paths(ipv4_path, ipv4_skeleton);
> +{
> + struct ctl_table_header *ctl_header;
> +
> + ctl_header = register_sysctl_paths(ipv4_path, ipv4_skeleton);
> + if (ctl_header)
> + kmemleak_not_leak(ctl_header);
> }
> #endif
No need for this temp var and conditional.
Just :
kmemleak_not_leak(register_sysctl_paths(ipv4_path, ipv4_skeleton));
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
@ 2012-04-17 5:33 majianpeng
2012-04-17 5:34 ` Eric Dumazet
2012-04-18 4:22 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: majianpeng @ 2012-04-17 5:33 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
>From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001
From: majianpeng <majianpeng@gmail.com>
Date: Tue, 17 Apr 2012 13:29:55 +0800
Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
Signed-off-by: majianpeng <majianpeng@gmail.com>
---
net/ipv4/route.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 167ea10..dd15648 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -3505,6 +3505,6 @@ int __init ip_rt_init(void)
*/
void __init ip_static_sysctl_init(void)
{
- register_sysctl_paths(ipv4_path, ipv4_skeleton);
+ kmemleak_not_leak(register_sysctl_paths(ipv4_path, ipv4_skeleton));
}
#endif
--
1.7.5.4
--------------
majianpeng
2012-04-17
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
2012-04-17 5:33 [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak majianpeng
@ 2012-04-17 5:34 ` Eric Dumazet
2012-04-18 4:22 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: Eric Dumazet @ 2012-04-17 5:34 UTC (permalink / raw)
To: majianpeng; +Cc: netdev
On Tue, 2012-04-17 at 13:33 +0800, majianpeng wrote:
> From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 17 Apr 2012 13:29:55 +0800
> Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
> net/ipv4/route.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 167ea10..dd15648 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -3505,6 +3505,6 @@ int __init ip_rt_init(void)
> */
> void __init ip_static_sysctl_init(void)
> {
> - register_sysctl_paths(ipv4_path, ipv4_skeleton);
> + kmemleak_not_leak(register_sysctl_paths(ipv4_path, ipv4_skeleton));
> }
> #endif
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
2012-04-17 5:33 [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak majianpeng
2012-04-17 5:34 ` Eric Dumazet
@ 2012-04-18 4:22 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2012-04-18 4:22 UTC (permalink / raw)
To: majianpeng; +Cc: eric.dumazet, netdev
From: "majianpeng" <majianpeng@gmail.com>
Date: Tue, 17 Apr 2012 13:33:31 +0800
>>From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 17 Apr 2012 13:29:55 +0800
> Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
I've applied both of your patches, but you are EXTREMELY careless
with your commit log messages and subject lines.
In this patch, and the net/core one, you misspell "kmemleak_not_leak"
In the net/core patch, you failed to separate "by" and "kmemleak_not_leak"
with a space in the Subject line.
Furthermore, it is extraneous to include the same From:, Date:, and
Subject: fields in the body of your email. They are just fine in
your normal email headers.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-18 4:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-17 1:41 [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak majianpeng
2012-04-17 5:18 ` Eric Dumazet
2012-04-17 5:22 ` Re: [PATCH] net/ipv4:Remove two memleak reports bykmemeleak_not_leak majianpeng
-- strict thread matches above, loose matches on Subject: below --
2012-04-17 5:33 [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak majianpeng
2012-04-17 5:34 ` Eric Dumazet
2012-04-18 4:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).