netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: majianpeng@gmail.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
Date: Wed, 18 Apr 2012 00:22:46 -0400 (EDT)	[thread overview]
Message-ID: <20120418.002246.1732341186957682813.davem@davemloft.net> (raw)
In-Reply-To: <201204171333149372727@gmail.com>

From: "majianpeng" <majianpeng@gmail.com>
Date: Tue, 17 Apr 2012 13:33:31 +0800

>>From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 17 Apr 2012 13:29:55 +0800
> Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
> 
> 
> Signed-off-by: majianpeng <majianpeng@gmail.com>

I've applied both of your patches, but you are EXTREMELY careless
with your commit log messages and subject lines.

In this patch, and the net/core one, you misspell "kmemleak_not_leak"

In the net/core patch, you failed to separate "by" and "kmemleak_not_leak"
with a space in the Subject line.

Furthermore, it is extraneous to include the same From:, Date:, and
Subject: fields in the body of your email.  They are just fine in
your normal email headers.

Thanks.

  parent reply	other threads:[~2012-04-18  4:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17  5:33 [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak majianpeng
2012-04-17  5:34 ` Eric Dumazet
2012-04-18  4:22 ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-17  1:41 majianpeng
2012-04-17  5:18 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418.002246.1732341186957682813.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=majianpeng@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).