From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: Tristram.Ha@micrel.com, bhutchings@solarflare.com,
netdev@vger.kernel.org
Subject: Re: [patch] ksz884x: don't copy too much in netdev_set_mac_address()
Date: Thu, 19 Apr 2012 13:25:58 -0400 (EDT) [thread overview]
Message-ID: <20120419.132558.135758710709714950.davem@davemloft.net> (raw)
In-Reply-To: <20120419070018.GA16645@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 19 Apr 2012 10:00:19 +0300
> MAX_ADDR_LEN is 32. ETH_ALEN is 6. mac->sa_data is a 14 byte array, so
> the memcpy() is doing a read past the end of the array. I asked about
> this on netdev and Ben Hutchings told me it's supposed to be copying
> ETH_ALEN bytes (thanks Ben).
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
prev parent reply other threads:[~2012-04-19 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 6:47 net: Micrel KSZ8841/2 PCI Ethernet driver Dan Carpenter
2012-04-18 14:13 ` Ben Hutchings
2012-04-18 14:51 ` Dan Carpenter
2012-04-19 7:00 ` [patch] ksz884x: don't copy too much in netdev_set_mac_address() Dan Carpenter
2012-04-19 17:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419.132558.135758710709714950.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Tristram.Ha@micrel.com \
--cc=bhutchings@solarflare.com \
--cc=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).