* [PATCH net-next] netlink: dont drop packet but consume it
@ 2012-04-19 12:24 Eric Dumazet
2012-04-19 18:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2012-04-19 12:24 UTC (permalink / raw)
To: David Miller; +Cc: netdev
From: Eric Dumazet <edumazet@google.com>
When we need to clone skb, we dont drop a packet.
Call consume_skb() to not confuse dropwatch.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/netlink/af_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index faa48f7..da87214 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -866,7 +866,7 @@ static struct sk_buff *netlink_trim(struct sk_buff *skb, gfp_t allocation)
struct sk_buff *nskb = skb_clone(skb, allocation);
if (!nskb)
return skb;
- kfree_skb(skb);
+ consume_skb(skb);
skb = nskb;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] netlink: dont drop packet but consume it
2012-04-19 12:24 [PATCH net-next] netlink: dont drop packet but consume it Eric Dumazet
@ 2012-04-19 18:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-04-19 18:24 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 19 Apr 2012 14:24:28 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> When we need to clone skb, we dont drop a packet.
> Call consume_skb() to not confuse dropwatch.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-19 18:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-19 12:24 [PATCH net-next] netlink: dont drop packet but consume it Eric Dumazet
2012-04-19 18:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).