From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: netdev@vger.kernel.org, ralf@linux-mips.org, linux-hams@vger.kernel.org
Subject: Re: [PATCH] net ax25: Reorder ax25_exit to remove races.
Date: Thu, 19 Apr 2012 15:38:05 -0400 (EDT) [thread overview]
Message-ID: <20120419.153805.1416561328432806364.davem@davemloft.net> (raw)
In-Reply-To: <m1hawgjws4.fsf@fess.ebiederm.org>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Wed, 18 Apr 2012 19:11:23 -0700
> While reviewing the sysctl code in ax25 I spotted races in ax25_exit
> where it is possible to receive notifications and packets after already
> freeing up some of the data structures needed to process those
> notifications and updates.
>
> Call unregister_netdevice_notifier early so that the rest of the cleanup
> code does not need to deal with network devices. This takes advantage
> of my recent enhancement to unregister_netdevice_notifier to send
> unregister notifications of all network devices that are current
> registered.
>
> Move the unregistration for packet types, socket types and protocol
> types before we cleanup any of the ax25 data structures to remove the
> possibilities of other races.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Applied, thanks a lot Eric.
prev parent reply other threads:[~2012-04-19 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 2:11 [PATCH] net ax25: Reorder ax25_exit to remove races Eric W. Biederman
2012-04-19 19:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419.153805.1416561328432806364.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).