From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, francesco.virlinzi@st.com
Subject: Re: [net-next 2/4 (v2)] stmmac: Move the mdio_register/_unregister in probe/remove
Date: Thu, 19 Apr 2012 20:09:11 -0400 (EDT) [thread overview]
Message-ID: <20120419.200911.266581260340706532.davem@davemloft.net> (raw)
In-Reply-To: <1334814502-29707-2-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Thu, 19 Apr 2012 07:48:20 +0200
> From: Francesco Virlinzi <francesco.virlinzi@st.com>
>
> This patch moves the mdio_register/_unregister in probe/remove
> functions and this also is required when hibernation on disk
> is done.
>
> ---
Because you put the "---" delimiter here, the signoffs would have
been deleted from the commit log message when I apply this with GIT
tools.
I caught it this time, but you need to be more careful about things
like this, and I still contend that you are very sloppy in your
patch submissions and exhibit a low attention to detail.
Anyways, applied.
> v2: remove useless open_clk_dis label and do a simple tidy-up
> in the open function.
>
> Signed-off-by: Francesco Virlinzi <francesco.virlinzi@st,com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st,com>
next prev parent reply other threads:[~2012-04-20 0:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 5:48 [net-next 1/4] stmmac: use custom init/exit functions in pm ops Giuseppe CAVALLARO
2012-04-19 5:48 ` [net-next 2/4 (v2)] stmmac: Move the mdio_register/_unregister in probe/remove Giuseppe CAVALLARO
2012-04-20 0:09 ` David Miller [this message]
2012-04-19 5:48 ` [net-next 3/4] stmmac: verify the dma_cfg platform fields Giuseppe CAVALLARO
2012-04-19 6:05 ` Viresh Kumar
2012-04-19 6:29 ` Giuseppe CAVALLARO
2012-04-20 0:09 ` David Miller
2012-04-19 5:48 ` [net-next 4/4] stmmac: do not fail when probe and there is no csr clk defined Giuseppe CAVALLARO
2012-04-20 0:09 ` David Miller
2012-04-20 0:06 ` [net-next 1/4] stmmac: use custom init/exit functions in pm ops David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419.200911.266581260340706532.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=francesco.virlinzi@st.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).