From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: rick.jones2@hp.com, netdev@vger.kernel.org, therbert@google.com,
ncardwell@google.com, maze@google.com, ycheng@google.com,
ilpo.jarvinen@helsinki.fi
Subject: Re: [PATCH 2/2 net-next] tcp: sk_add_backlog() is too agressive for TCP
Date: Mon, 23 Apr 2012 17:01:01 -0400 (EDT) [thread overview]
Message-ID: <20120423.170101.1369764871919045849.davem@davemloft.net> (raw)
In-Reply-To: <1335213446.5205.65.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 23 Apr 2012 22:37:26 +0200
> We could try to coalesce ACKs before backlogging them. I'll work on
> this.
Great idea, although I wonder about the effect this could have on RTT
measurements. Instead of having N RTT measurements, we'd have just
one.
Granted, what happens right now wrt. RTT measurements with such huge
ACK backlogs isn't all that nice either.
Ideally, perhaps, we'd do a timestamp diff at the time we insert the
packet into the backlog. That way we wouldn't gain the RTT inaccuracy
introduced by such queueing delays and ACK backlogs.
Another way to look at it is that the coalesced scheme would actually
improve RTT measurements, since the most accurate (and least
"delayed") of the timestamps would be the only one processed :-)
next prev parent reply other threads:[~2012-04-23 21:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 9:38 [PATCH 2/2 net-next] tcp: sk_add_backlog() is too agressive for TCP Eric Dumazet
2012-04-23 17:14 ` Rick Jones
2012-04-23 17:23 ` Eric Dumazet
2012-04-23 20:01 ` David Miller
2012-04-23 20:37 ` Eric Dumazet
2012-04-23 20:57 ` Rick Jones
2012-04-23 21:30 ` Eric Dumazet
2012-04-23 21:51 ` Rick Jones
2012-04-23 21:56 ` Rick Jones
2012-04-23 22:05 ` Eric Dumazet
2012-04-23 22:16 ` Rick Jones
2012-04-24 15:25 ` Christoph Lameter
2012-04-23 21:01 ` David Miller [this message]
2012-04-23 21:38 ` Eric Dumazet
2012-04-24 2:20 ` Eric Dumazet
2012-04-24 2:27 ` David Miller
2012-04-24 8:01 ` Ilpo Järvinen
2012-04-24 8:10 ` David Miller
2012-04-24 8:21 ` Ilpo Järvinen
2012-04-24 8:25 ` David Miller
2012-04-24 8:40 ` Ilpo Järvinen
2012-04-24 8:48 ` David Miller
2012-04-24 10:32 ` Ilpo Järvinen
2012-04-24 8:56 ` Eric Dumazet
2012-04-26 8:10 ` [RFC] allow skb->head to point/alias to first skb frag Eric Dumazet
2012-04-26 8:36 ` David Miller
2012-04-26 9:10 ` Eric Dumazet
2012-04-26 9:18 ` David Miller
2012-04-26 9:22 ` Eric Dumazet
2012-04-26 10:09 ` Maciej Żenczykowski
2012-04-26 12:32 ` Eric Dumazet
2012-04-26 13:50 ` Eric Dumazet
2012-04-26 20:12 ` David Miller
2012-04-26 20:18 ` Eric Dumazet
2012-04-24 8:49 ` [PATCH 2/2 net-next] tcp: sk_add_backlog() is too agressive for TCP Eric Dumazet
2012-04-24 8:44 ` David Laight
2012-04-24 8:53 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423.170101.1369764871919045849.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=maze@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=therbert@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).