* [patch 0/2] s390: qeth bug fixes for net
@ 2012-04-23 7:21 frank.blaschka
2012-04-23 7:21 ` [patch 1/2] [PATCH] qeth: allow change of blkt default values frank.blaschka
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: frank.blaschka @ 2012-04-23 7:21 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-s390
Hi Dave,
here are two small qeth bug fixes for net.
shortlog:
Ursula Braun (1)
qeth: allow change of blkt default values
Stefan Raspl (1)
qeth: Use blkt defaults for OSA Express 4
Thanks,
Frank
^ permalink raw reply [flat|nested] 4+ messages in thread* [patch 1/2] [PATCH] qeth: allow change of blkt default values
2012-04-23 7:21 [patch 0/2] s390: qeth bug fixes for net frank.blaschka
@ 2012-04-23 7:21 ` frank.blaschka
2012-04-23 7:21 ` [patch 2/2] [PATCH] qeth: Use blkt defaults for OSA Express 4 frank.blaschka
2012-04-24 4:33 ` [patch 0/2] s390: qeth bug fixes for net David Miller
2 siblings, 0 replies; 4+ messages in thread
From: frank.blaschka @ 2012-04-23 7:21 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-s390, Ursula Braun
[-- Attachment #1: 600-qeth-blkt-default.diff --]
[-- Type: text/plain, Size: 1034 bytes --]
From: Ursula Braun <ursula.braun@de.ibm.com>
There exist qeth sysfs blkt attributes to change the default blkt
values. But blkt changes are reset during online setting due to a 2nd
invocation of qeth_determine_capabilites(). This patch makes sure
blkt default values are configured during 1st run of
qeth_determine_capabilities() only. Thus blkt changes are kept
during online setting.
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Reported-by: Horst Hartmann <horst.hartmann@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---
drivers/s390/net/qeth_core_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -4540,7 +4540,8 @@ static void qeth_determine_capabilities(
goto out_offline;
}
qeth_configure_unitaddr(card, prcd);
- qeth_configure_blkt_default(card, prcd);
+ if (ddev_offline)
+ qeth_configure_blkt_default(card, prcd);
kfree(prcd);
rc = qdio_get_ssqd_desc(ddev, &card->ssqd);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch 2/2] [PATCH] qeth: Use blkt defaults for OSA Express 4
2012-04-23 7:21 [patch 0/2] s390: qeth bug fixes for net frank.blaschka
2012-04-23 7:21 ` [patch 1/2] [PATCH] qeth: allow change of blkt default values frank.blaschka
@ 2012-04-23 7:21 ` frank.blaschka
2012-04-24 4:33 ` [patch 0/2] s390: qeth bug fixes for net David Miller
2 siblings, 0 replies; 4+ messages in thread
From: frank.blaschka @ 2012-04-23 7:21 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-s390, Stefan Raspl
[-- Attachment #1: 601-qeth-blkt-defaults.diff --]
[-- Type: text/plain, Size: 950 bytes --]
From: Stefan Raspl <raspl@linux.vnet.ibm.com>
The previous blkt defaults for OSA Express 4 cards produced inadequate
performance for streaming workloads. The present patch will apply a
set of more appropriate defaults.
Signed-off-by: Stefan Raspl <raspl@linux.vnet.ibm.com>
Reviewed-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---
drivers/s390/net/qeth_core_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -1672,7 +1672,8 @@ static void qeth_configure_blkt_default(
{
QETH_DBF_TEXT(SETUP, 2, "cfgblkt");
- if (prcd[74] == 0xF0 && prcd[75] == 0xF0 && prcd[76] == 0xF5) {
+ if (prcd[74] == 0xF0 && prcd[75] == 0xF0 &&
+ (prcd[76] == 0xF5 || prcd[76] == 0xF6)) {
card->info.blkt.time_total = 250;
card->info.blkt.inter_packet = 5;
card->info.blkt.inter_packet_jumbo = 15;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch 0/2] s390: qeth bug fixes for net
2012-04-23 7:21 [patch 0/2] s390: qeth bug fixes for net frank.blaschka
2012-04-23 7:21 ` [patch 1/2] [PATCH] qeth: allow change of blkt default values frank.blaschka
2012-04-23 7:21 ` [patch 2/2] [PATCH] qeth: Use blkt defaults for OSA Express 4 frank.blaschka
@ 2012-04-24 4:33 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-04-24 4:33 UTC (permalink / raw)
To: frank.blaschka; +Cc: netdev, linux-s390
From: frank.blaschka@de.ibm.com
Date: Mon, 23 Apr 2012 09:21:40 +0200
> here are two small qeth bug fixes for net.
>
> shortlog:
>
> Ursula Braun (1)
> qeth: allow change of blkt default values
>
> Stefan Raspl (1)
> qeth: Use blkt defaults for OSA Express 4
Both applied, thanks Frank.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-04-24 4:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-23 7:21 [patch 0/2] s390: qeth bug fixes for net frank.blaschka
2012-04-23 7:21 ` [patch 1/2] [PATCH] qeth: allow change of blkt default values frank.blaschka
2012-04-23 7:21 ` [patch 2/2] [PATCH] qeth: Use blkt defaults for OSA Express 4 frank.blaschka
2012-04-24 4:33 ` [patch 0/2] s390: qeth bug fixes for net David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).