From: Stephane Fillod <fillods@users.sf.net>
To: Paolo Pisati <paolo.pisati@canonical.com>
Cc: Steve Glendinning <steve.glendinning@shawell.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes
Date: Mon, 23 Apr 2012 21:43:39 +0200 [thread overview]
Message-ID: <20120423194339.GS5277@charybde.local> (raw)
In-Reply-To: <1335189920-31062-1-git-send-email-paolo.pisati@canonical.com>
lun, Apr 23, 2012, Paolo Pisati skribis:
> Without this patch sysfs reports the cable as present
>
> flag@flag-desktop:~$ cat /sys/class/net/eth0/carrier
> 1
>
> while it's not:
>
> flag@flag-desktop:~$ sudo mii-tool eth0
> eth0: no link
>
> Tested on my Beagle XM.
>
> v2: added mantainer to the list of recipient
His e-mail address has changed, but somehow it has not been updated yet
in MAINTAINERS directory: steve.glendinning () shawell.net
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
> drivers/net/usb/smsc95xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index 3444514..93d3252 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -1192,7 +1192,7 @@ static const struct driver_info smsc95xx_info = {
> .rx_fixup = smsc95xx_rx_fixup,
> .tx_fixup = smsc95xx_tx_fixup,
> .status = smsc95xx_status,
> - .flags = FLAG_ETHER | FLAG_SEND_ZLP,
> + .flags = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
> };
>
> static const struct usb_device_id products[] = {
Tested this fix successfuly on elder brother smsc75xx, on top of
another patch yet-to-submit to fix smsc75xx's MDIO access.
next prev parent reply other threads:[~2012-04-23 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 14:05 [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes Paolo Pisati
2012-04-23 19:43 ` Stephane Fillod [this message]
2012-04-24 4:42 ` David Miller
2012-04-24 15:45 ` Steve Glendinning
2012-04-26 9:41 ` Steve Glendinning
2012-04-26 9:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423194339.GS5277@charybde.local \
--to=fillods@users.sf.net \
--cc=netdev@vger.kernel.org \
--cc=paolo.pisati@canonical.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).