* [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes
@ 2012-04-23 14:05 Paolo Pisati
2012-04-23 19:43 ` Stephane Fillod
0 siblings, 1 reply; 6+ messages in thread
From: Paolo Pisati @ 2012-04-23 14:05 UTC (permalink / raw)
To: Steve Glendinning; +Cc: netdev, Paolo Pisati
Without this patch sysfs reports the cable as present
flag@flag-desktop:~$ cat /sys/class/net/eth0/carrier
1
while it's not:
flag@flag-desktop:~$ sudo mii-tool eth0
eth0: no link
Tested on my Beagle XM.
v2: added mantainer to the list of recipient
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
drivers/net/usb/smsc95xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 3444514..93d3252 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -1192,7 +1192,7 @@ static const struct driver_info smsc95xx_info = {
.rx_fixup = smsc95xx_rx_fixup,
.tx_fixup = smsc95xx_tx_fixup,
.status = smsc95xx_status,
- .flags = FLAG_ETHER | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
};
static const struct usb_device_id products[] = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes
2012-04-23 14:05 [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes Paolo Pisati
@ 2012-04-23 19:43 ` Stephane Fillod
2012-04-24 4:42 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Stephane Fillod @ 2012-04-23 19:43 UTC (permalink / raw)
To: Paolo Pisati; +Cc: Steve Glendinning, netdev
lun, Apr 23, 2012, Paolo Pisati skribis:
> Without this patch sysfs reports the cable as present
>
> flag@flag-desktop:~$ cat /sys/class/net/eth0/carrier
> 1
>
> while it's not:
>
> flag@flag-desktop:~$ sudo mii-tool eth0
> eth0: no link
>
> Tested on my Beagle XM.
>
> v2: added mantainer to the list of recipient
His e-mail address has changed, but somehow it has not been updated yet
in MAINTAINERS directory: steve.glendinning () shawell.net
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
> drivers/net/usb/smsc95xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index 3444514..93d3252 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -1192,7 +1192,7 @@ static const struct driver_info smsc95xx_info = {
> .rx_fixup = smsc95xx_rx_fixup,
> .tx_fixup = smsc95xx_tx_fixup,
> .status = smsc95xx_status,
> - .flags = FLAG_ETHER | FLAG_SEND_ZLP,
> + .flags = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
> };
>
> static const struct usb_device_id products[] = {
Tested this fix successfuly on elder brother smsc75xx, on top of
another patch yet-to-submit to fix smsc75xx's MDIO access.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes
2012-04-23 19:43 ` Stephane Fillod
@ 2012-04-24 4:42 ` David Miller
2012-04-24 15:45 ` Steve Glendinning
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2012-04-24 4:42 UTC (permalink / raw)
To: fillods; +Cc: paolo.pisati, steve.glendinning, netdev
From: Stephane Fillod <fillods@users.sf.net>
Date: Mon, 23 Apr 2012 21:43:39 +0200
> lun, Apr 23, 2012, Paolo Pisati skribis:
>> Without this patch sysfs reports the cable as present
>>
>> flag@flag-desktop:~$ cat /sys/class/net/eth0/carrier
>> 1
>>
>> while it's not:
>>
>> flag@flag-desktop:~$ sudo mii-tool eth0
>> eth0: no link
>>
>> Tested on my Beagle XM.
>>
>> v2: added mantainer to the list of recipient
>
> His e-mail address has changed, but somehow it has not been updated yet
> in MAINTAINERS directory: steve.glendinning () shawell.net
Steve, please send a maintainers etc. update and please provide
feedback on this link status fix.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes
2012-04-24 4:42 ` David Miller
@ 2012-04-24 15:45 ` Steve Glendinning
2012-04-26 9:41 ` Steve Glendinning
0 siblings, 1 reply; 6+ messages in thread
From: Steve Glendinning @ 2012-04-24 15:45 UTC (permalink / raw)
To: David Miller; +Cc: fillods, paolo.pisati, steve.glendinning, netdev
Hi all,
On 24 April 2012 05:42, David Miller <davem@davemloft.net> wrote:
>>> v2: added mantainer to the list of recipient
>>
>> His e-mail address has changed, but somehow it has not been updated yet
>> in MAINTAINERS directory: steve.glendinning () shawell.net
>
> Steve, please send a maintainers etc. update and please provide
> feedback on this link status fix.
I submitted an update to MAINTAINERS last week, I don't think it's
been picked up yet.
Thanks for the patch Paulo, I'd like to test this out. I'll get back
to you in a few days.
--
Steve Glendinning
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes
2012-04-24 15:45 ` Steve Glendinning
@ 2012-04-26 9:41 ` Steve Glendinning
2012-04-26 9:56 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Steve Glendinning @ 2012-04-26 9:41 UTC (permalink / raw)
To: David Miller; +Cc: fillods, paolo.pisati, netdev
Hi all,
On 24 April 2012 16:45, Steve Glendinning <steve@shawell.net> wrote:
> Hi all,
>
> On 24 April 2012 05:42, David Miller <davem@davemloft.net> wrote:
>>
>> Steve, please send a maintainers etc. update and please provide
>> feedback on this link status fix.
Good catch Paolo, this patch fixes reporting of link status when the
device is first connected with no ethernet cable plugged in.
I'll prepare the same patch for smsc75xx as it also suffers from the same issue.
Acked-by: Steve Glendinning <steve.glendinning@shawell.net>
--
Steve Glendinning
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes
2012-04-26 9:41 ` Steve Glendinning
@ 2012-04-26 9:56 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-04-26 9:56 UTC (permalink / raw)
To: steve; +Cc: fillods, paolo.pisati, netdev
From: Steve Glendinning <steve@shawell.net>
Date: Thu, 26 Apr 2012 10:41:33 +0100
> Hi all,
>
> On 24 April 2012 16:45, Steve Glendinning <steve@shawell.net> wrote:
>> Hi all,
>>
>> On 24 April 2012 05:42, David Miller <davem@davemloft.net> wrote:
>>>
>>> Steve, please send a maintainers etc. update and please provide
>>> feedback on this link status fix.
>
> Good catch Paolo, this patch fixes reporting of link status when the
> device is first connected with no ethernet cable plugged in.
>
> I'll prepare the same patch for smsc75xx as it also suffers from the same issue.
>
> Acked-by: Steve Glendinning <steve.glendinning@shawell.net>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-26 9:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-23 14:05 [PATCH v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes Paolo Pisati
2012-04-23 19:43 ` Stephane Fillod
2012-04-24 4:42 ` David Miller
2012-04-24 15:45 ` Steve Glendinning
2012-04-26 9:41 ` Steve Glendinning
2012-04-26 9:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).