From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: linus.walleij@linaro.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
balbi@ti.com, jussi.kivilinna@mbnet.fi,
yongjun_wei@trendmicro.com.cn, ben@decadent.org.uk
Subject: Re: [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h> defines
Date: Wed, 25 Apr 2012 19:45:45 -0400 (EDT) [thread overview]
Message-ID: <20120425.194545.1399301965144213487.davem@davemloft.net> (raw)
In-Reply-To: <A1F3067C9B68744AA19F6802BAB8FFDC0DD36CAE@TK5EX14MBXC221.redmond.corp.microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Wed, 25 Apr 2012 20:38:31 +0000
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
I don't think you really thoroughly reviewed this patch, otherwise
you would have noticed the duplicate definitions that result from
this patch which adds hundreds of warnings to the build.
next prev parent reply other threads:[~2012-04-25 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 15:30 [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h> defines Linus Walleij
2012-04-25 20:38 ` Haiyang Zhang
2012-04-25 23:45 ` David Miller [this message]
[not found] ` <20120425.194545.1399301965144213487.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-04-26 13:00 ` Haiyang Zhang
[not found] ` <1335367808-4254-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-04-25 23:44 ` David Miller
[not found] ` <20120425.194447.1519804940735129000.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-04-27 11:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425.194545.1399301965144213487.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=balbi@ti.com \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linus.walleij@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).