From: David Miller <davem@davemloft.net>
To: xemul@parallels.com, xemul@sacred.ru
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] tcp repair: Fix unaligned access when repairing options (v2)
Date: Thu, 26 Apr 2012 06:14:17 -0400 (EDT) [thread overview]
Message-ID: <20120426.061417.1835457785025147124.davem@davemloft.net> (raw)
In-Reply-To: <4F9918A8.20100@sacred.ru>
From: Pavel Emelyanov <xemul@sacred.ru>
Date: Thu, 26 Apr 2012 13:43:04 +0400
> From: Pavel Emelyanov <xemul@parallels.com>
>
> Don't pick __u8/__u16 values directly from raw pointers, but instead use
> an array of structures of code:value pairs. This is OK, since the buffer
> we take options from is not an skb memory, but a user-to-kernel one.
>
> For those options which don't require any value now, require this to be
> zero (for potential future extension of this API).
>
> v2: Changed tcp_repair_opt to use two __u32-s as spotted by David Laight.
>
> Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Seems to have worked this time, applied :-)
next prev parent reply other threads:[~2012-04-26 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 9:43 [PATCH] tcp repair: Fix unaligned access when repairing options (v2) Pavel Emelyanov
2012-04-26 10:14 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-26 8:50 Pavel Emelyanov
2012-04-26 9:23 ` David Miller
2012-04-26 9:41 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426.061417.1835457785025147124.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
--cc=xemul@sacred.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).