From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: wireless: mwifiex: initial commit for Marvell mwifiex driver
Date: Thu, 26 Apr 2012 15:51:02 +0300 [thread overview]
Message-ID: <20120426125102.GA14808@mwanda> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F7043083A3CC5FF@SC-VEXCH1.marvell.com>
On Wed, Apr 25, 2012 at 03:08:33PM -0700, Bing Zhao wrote:
> > ->oui is only a 3 byte array so we're reading past the end for this
> > comparison.
>
> I will fix the misuse of memcmp's.
>
So it wasn't really a bug right? Just a bit confusing.
> By the way, could you please share with me how you check for this kind of errors?
> Is it coccinelle? I tried with coccicheck but got "spatch.opt unknown option -D" error.
>
This was from a Smatch check that I haven't pushed yet.
regards,
dan carpenter
next prev parent reply other threads:[~2012-04-26 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 8:44 wireless: mwifiex: initial commit for Marvell mwifiex driver Dan Carpenter
2012-04-25 22:08 ` Bing Zhao
2012-04-26 12:51 ` Dan Carpenter [this message]
2012-04-26 19:25 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426125102.GA14808@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bzhao@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).