From: Simon Horman <horms@verge.net.au>
To: Julian Anastasov <ja@ssi.bg>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] IPVS: ip_vs_sync.c: local functions should not be exposed globally
Date: Fri, 27 Apr 2012 09:57:13 +0900 [thread overview]
Message-ID: <20120427005713.GC5105@verge.net.au> (raw)
In-Reply-To: <alpine.LFD.2.00.1204262301160.2078@ja.ssi.bg>
On Thu, Apr 26, 2012 at 11:11:54PM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Thu, 26 Apr 2012, H Hartley Sweeten wrote:
>
> > Functions not referenced outside of a source file should be marked
> > static to prevent it from being exposed globally.
> >
> > This quiets the sparse warnings:
> >
> > warning: symbol 'ip_vs_sync_conn_v0' was not declared. Should it be static?
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > Cc: "David S. Miller" <davem@davemloft.net>
> >
> > ---
> >
> > diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> > index bf5e538..49a1fe8 100644
> > --- a/net/netfilter/ipvs/ip_vs_sync.c
> > +++ b/net/netfilter/ipvs/ip_vs_sync.c
> > @@ -446,7 +446,7 @@ ip_vs_sync_buff_create_v0(struct netns_ipvs *ipvs)
> > * Version 0 , could be switched in by sys_ctl.
> > * Add an ip_vs_conn information into the current sync_buff.
> > */
> > -void ip_vs_sync_conn_v0(struct net *net, struct ip_vs_conn *cp)
> > +static void ip_vs_sync_conn_v0(struct net *net, struct ip_vs_conn *cp)
>
> The 3 patches for IPVS look correct but this change
> is already not needed after one of our planned changes:
>
> "ipvs: reduce sync rate with time thresholds"
>
> Not sure how we will avoid the collision, may be
> Simon will take only the other 2 changes? Or David will
> take all changes and we have to rebase?
I think the best way forwards is for me to take only the first two changes.
I don't think that this fix is 3.4 material and as you say we expect this
problem to be resolved by other means in 3.5.
I am of course open to discussion on this.
prev parent reply other threads:[~2012-04-27 0:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 18:29 [PATCH] IPVS: ip_vs_sync.c: local functions should not be exposed globally H Hartley Sweeten
2012-04-26 20:11 ` Julian Anastasov
2012-04-27 0:57 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427005713.GC5105@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=ja@ssi.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).