From: Simon Horman <horms@verge.net.au>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] IPVS: ip_vs_ftp.c: local functions should not be exposed globally
Date: Fri, 27 Apr 2012 10:01:40 +0900 [thread overview]
Message-ID: <20120427010140.GD5105@verge.net.au> (raw)
In-Reply-To: <201204261126.15699.hartleys@visionengravers.com> <201204261117.28491.hartleys@visionengravers.com>
On Thu, Apr 26, 2012 at 11:17:28AM -0700, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent it from being exposed globally.
>
> This quiets the sparse warnings:
>
> warning: symbol 'ip_vs_ftp_init' was not declared. Should it be static?
On Thu, Apr 26, 2012 at 11:26:15AM -0700, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent it from being exposed globally.
>
> This quiets the sparse warnings:
>
> warning: symbol '__ipvs_proto_data_get' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: "David S. Miller" <davem@davemloft.net>
Thanks, I have applied these to ipvs-next.
git://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git
prev parent reply other threads:[~2012-04-27 1:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 18:26 [PATCH] IPVS: ip_vs_proto.c: local functions should not be exposed globally H Hartley Sweeten
2012-04-26 18:17 ` [PATCH] IPVS: ip_vs_ftp.c: " H Hartley Sweeten
2012-04-27 1:01 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427010140.GD5105@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).