From: David Miller <davem@davemloft.net>
To: fillods@users.sf.net
Cc: netdev@vger.kernel.org, steve.glendinning@shawell.net
Subject: Re: [PATCH] net: smsc75xx: fix MDIO access
Date: Sat, 28 Apr 2012 21:55:36 -0400 (EDT) [thread overview]
Message-ID: <20120428.215536.1073848205954371267.davem@davemloft.net> (raw)
In-Reply-To: <20120426195517.GU5277@charybde.local>
From: Stephane Fillod <fillods@users.sf.net>
Date: Thu, 26 Apr 2012 21:55:17 +0200
> * make MDIO read/write to work, the MII_ACCESS_BUSY bit was missing
> to actually trigger the I/O. Rem: the smsc75xx is different from
> the smsc95xx in that regard.
> * fix PHY interrupt acknowledge, which needs a mdio_write
> to clear PHY_INT_SRC instead of a usual read like in smsc95xx.
> * fix bug in phy_init loop that was ignoring BMCR reset bit,
> akin to smsc95xx's d946092000698fd204d82a9d239103c656fb63bf
> * mark link down on startup and let PHY interrupt deal with carrier
> changes, akin to 07d69d4238418746a7b85c5d05ec17c658a2a390
> * declare the smsc75xx's MII as GMII capable
>
> Tested on ARM/Omap3 with LAN7500-CEB.
>
> Signed-off-by: Stephane Fillod <fillods@users.sf.net>
> Cc: Steve Glendinning <steve.glendinning@shawell.net>
Steve, could you give this a quick review?
Thanks.
prev parent reply other threads:[~2012-04-29 1:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 19:55 [PATCH] net: smsc75xx: fix MDIO access Stephane Fillod
2012-04-29 1:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120428.215536.1073848205954371267.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fillods@users.sf.net \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).